Conversation
There was a problem hiding this comment.
Pull request overview
Updates the NAPI/EMNAPI toolchain used by rspack’s Rust ↔ Node/WASM bindings so the repo builds against newer napi-rs ecosystem versions.
Changes:
- Bump Rust workspace pins for
napi,napi-build, andnapi-derive(and updateCargo.lockaccordingly). - Bump Node-side tooling/runtime deps (
@napi-rs/cli,@napi-rs/wasm-runtime,emnapi) and refreshpnpm-lock.yaml. - Adjust WASI loader fallback resolution to locate the
.wasmasset viarequire.resolve.
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile refresh reflecting updated napi/wasm-runtime/emnapi and transitive deps. |
| packages/rspack/package.json | Bump @napi-rs/wasm-runtime to 1.1.1. |
| packages/rspack-browser/package.json | Bump @napi-rs/wasm-runtime to 1.1.1. |
| npm/wasm32-wasi/package.json | Bump @napi-rs/wasm-runtime to 1.1.1 for the WASI binding package. |
| crates/rspack_binding_builder_testing/package.json | Bump @napi-rs/cli, @napi-rs/wasm-runtime, emnapi. |
| crates/node_binding/rspack.wasi.cjs | Update WASM file resolution fallback logic + formatting changes from regen. |
| crates/node_binding/package.json | Bump @napi-rs/cli, @napi-rs/wasm-runtime, emnapi. |
| crates/node_binding/napi-binding.d.ts | Regenerated typings; includes a JSDoc formatting regression (commented). |
| Cargo.toml | Bump pinned Rust napi crates; minor lint config formatting change. |
| Cargo.lock | Lock updates for bumped napi crates and their dependency graph changes. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
📦 Binary Size-limit
❌ Size increased by 133.00KB from 48.66MB to 48.79MB (⬆️0.27%) |
Rsdoctor Bundle Diff Analysis
Found 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will not alter performance
Comparing Footnotes
|
48381ba to
a23b8e8
Compare
5675d7e to
23c8c52
Compare
b34b49e to
bad3b39
Compare
bad3b39 to
7fcf97d
Compare
This reverts commit 7fcf97d.
Summary
crates:
packages:
Investigation of binary bloat
Error.causesupport tonapi::Errornapi-rs/napi-rs#2829 adds theBox<Error>tonapi::Error, which will be inlined in most all of thefrom_napi_value. Local test that reverts that commit shows a reduce of 50 ~ 70KB optimization.node_api_create_object_with_properties.Checklist