fix: optimize concatenated module code generation hot paths#13375
Merged
LingyuCoder merged 9 commits intomainfrom Mar 18, 2026
Merged
fix: optimize concatenated module code generation hot paths#13375LingyuCoder merged 9 commits intomainfrom
LingyuCoder merged 9 commits intomainfrom
Conversation
github-actions
Bot
added
team
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces ConcatenatedModule code generation overhead by optimizing name allocation and moving an expensive map teardown (module_to_info_map) off the hot path via background drop, with added unit tests to lock in identifier-splitting and name-conflict behavior.
Changes:
- Optimized
find_new_name(bothNameAllocatorand standalone) by reusing string buffers and avoiding repeated identifier-start checks/allocation. - Swapped out
module_to_info_mapand dropped the old map on a blocking thread usingfast_setto reduce critical-path teardown cost. - Added unit tests for
split_readable_identifierordering andfind_new_nameconflict-resolution stability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
📦 Binary Size-limit
❌ Size increased by 21.63KB from 48.70MB to 48.72MB (⬆️0.04%) |
Merging this PR will not alter performance
Comparing 
Footnotes
|
LingyuCoder
force-pushed
the
codex/optimize-find-new-name
branch
from
871cbaa to
1f70962
Compare
LingyuCoder
changed the title
LingyuCoder
force-pushed
the
codex/optimize-find-new-name
branch
from
fffa8ba to
54750ea
Compare
Deploying rspack with
|
| Latest commit: |
54750ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c604c313.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-optimize-find-new-name.rspack-v2.pages.dev |
LingyuCoder
force-pushed
the
codex/optimize-find-new-name
branch
from
54750ea to
b67ec06
Compare
LingyuCoder
force-pushed
the
codex/optimize-find-new-name
branch
from
b67ec06 to
f3c4e43
Compare
Contributor
|
📝 Benchmark detail: Open
|
Contributor
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3c4e4394c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
JSerFeng
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReplaceSourceinstances during final source assembly by movinginfo.sourceandchunk_init_fragmentsout ofmodule_to_info_mapConcatenatedModule-specific code generation hash fast path based on the precomputed module hash plus lightweight metadatamodule_to_info_map,NameAllocator,escaped_names,escaped_identifiers, andchangesafter they are no longer neededChecklist