Skip to content

feat: add disconnect on event source wrapper#367

Open
clarkdo wants to merge 1 commit into
webpack:masterfrom
clarkdo:disconect
Open

feat: add disconnect on event source wrapper#367
clarkdo wants to merge 1 commit into
webpack:masterfrom
clarkdo:disconect

Conversation

@clarkdo

@clarkdo clarkdo commented Oct 6, 2019

Copy link
Copy Markdown

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add disconect on EventSourceWrapper for making close eventSource manually possible.

Breaking Changes

Additional Info

@glenjamin

Copy link
Copy Markdown
Contributor

This code appears correct, but could you describe a use-case which would motivate doing this?

@clarkdo

clarkdo commented Oct 6, 2019

Copy link
Copy Markdown
Author

My case is that I want to close connection if the browser tab is hidden or minimized and refresh page when tab gets activated again for preventing reaching connection limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants