Skip to content

replace source-map with source-map-sync#102

Closed
7rulnik wants to merge 5 commits into
webpack:mainfrom
7rulnik:sync-wasm
Closed

replace source-map with source-map-sync#102
7rulnik wants to merge 5 commits into
webpack:mainfrom
7rulnik:sync-wasm

Conversation

@7rulnik

@7rulnik 7rulnik commented Feb 14, 2021

Copy link
Copy Markdown

No description provided.

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is different with source-map-js?

@7rulnik

7rulnik commented Feb 14, 2021

Copy link
Copy Markdown
Author

@alexander-akait it's the original source-map with WASM, but with sync API. It's should be 2x faster than source-map-js. I will make a PR to source-map that easily to review.

@alexander-akait

Copy link
Copy Markdown
Member

Do you have repo?

@7rulnik

7rulnik commented Feb 14, 2021

Copy link
Copy Markdown
Author

@alexander-akait 7rulnik/source-map-sync#1

@7rulnik 7rulnik marked this pull request as ready for review February 14, 2021 22:49
@alexander-akait

Copy link
Copy Markdown
Member

Some developers bundle webpack, it is rare case, but it can be breaking change for them

@7rulnik

7rulnik commented Feb 15, 2021

Copy link
Copy Markdown
Author

Yeah, I think that I can transform WASM into base64 so it will be not a problem

@7rulnik

7rulnik commented Feb 15, 2021

Copy link
Copy Markdown
Author

@alexander-akait should be bundleable now :)

@7rulnik

7rulnik commented Jul 27, 2021

Copy link
Copy Markdown
Author

#34 (comment)

@7rulnik 7rulnik closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants