fix: design-review a11y + token fixes (#321 #322 #323 #325)#327
Merged
Conversation
…oken hygiene Batch closing the auto-filed a11y/token issues (fixes verified against current code; accent-hover color math independently re-derived): - #321: search input gains aria-label + a visible :focus-visible ring (was outline:none with no keyboard indicator); dialog boundary uses --color-border-bold not the decorative --color-border - #322: mobile primary nav no longer shrinks to 13px (--text-micro); kept at the 14px floor, tightened gap/tracking instead - #323: --color-accent-hover was out-of-sRGB-gamut (clipped, 4.27:1); now oklch(0.50 0.10 75) — in-gamut, 5.27:1. ALSO added accent-hover to contrast-audit + apca-audit required pairs so CI covers it (the token was previously unaudited — the real gap #323 named) - #325: theme-color meta corrected to match --color-bg (#f5ede4/#060b05); hardcoded 0.875rem search sizes -> var(--text-meta) Verified: contrast (accent-hover 5.27:1 light / 9.72:1 dark) + APCA (70.1 light) pass, build green, accent-font lint clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
williamzujkowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groomed batch closing four auto-filed issues. Fixes verified against current code (independently re-checked the #323 color math) plus the missing CI coverage added.
Closes #321, closes #322, closes #323, closes #325.
Contrast + APCA + build + accent-font lint all green.
🤖 Generated with Claude Code