Skip to content

fix: read confirmation on reply from notification (WPB-8756)#3975

Merged
sbakhtiarov merged 2 commits intodevelopfrom
fix/reply-read-receipt
Apr 7, 2026
Merged

fix: read confirmation on reply from notification (WPB-8756)#3975
sbakhtiarov merged 2 commits intodevelopfrom
fix/reply-read-receipt

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

@sbakhtiarov sbakhtiarov commented Mar 17, 2026

https://wearezeta.atlassian.net/browse/WPB-8756

https://wearezeta.atlassian.net/browse/WPB-8756

What's new in this PR?

Issues

See issue description here: wireapp/wire-android#4658

Solutions

Adding new flag to bypass the 3 second delay for updating the last read date and sending read receipt.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 17, 2026

Test Results

0 tests   - 4 656   0 ✅  - 4 539   0s ⏱️ - 2m 44s
0 suites  -   773   0 💤  -   117 
0 files    -   773   0 ❌ ±    0 

Results for commit f4e014e. ± Comparison against base commit 38ce4ce.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.97%. Comparing base (38ce4ce) to head (f4e014e).
⚠️ Report is 62 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3975      +/-   ##
===========================================
- Coverage    59.97%   59.97%   -0.01%     
===========================================
  Files         1983     1983              
  Lines        64186    64191       +5     
  Branches      7005     7004       -1     
===========================================
+ Hits         38497    38499       +2     
  Misses       22542    22542              
- Partials      3147     3150       +3     
Files with missing lines Coverage Δ
.../conversation/UpdateConversationReadDateUseCase.kt 93.87% <100.00%> (+0.69%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ce4ce...f4e014e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 17, 2026

🐰 Bencher Report

Branchfix/reply-read-receipt
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
928.30 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
580,628.37 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,366,158.31 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,195.42 µs
🐰 View full continuous benchmarking report in Bencher

@sonarqubecloud
Copy link
Copy Markdown

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Apr 7, 2026
Merged via the queue into develop with commit 7906c1c Apr 7, 2026
26 checks passed
@sbakhtiarov sbakhtiarov deleted the fix/reply-read-receipt branch April 7, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants