-
Notifications
You must be signed in to change notification settings - Fork 46
fix: stabilize message media loading [WPB-18914] #4687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3632c05
fix: message list loading
Garzas 70c24f0
Merge branch 'develop' into fix/message-list-loading
Garzas 0622a92
fix: stabilize message media loading by removing local asset path fro…
Garzas 0d8b247
chore: migrate scoped ViewModels to Resaca 5 assisted factories
Garzas 7686ef6
tests fixes
Garzas 074e95f
fix: stabilize scoped VMs in message list with resaca key resolver
Garzas 75b9ea9
simplify asset local-path state and center media loading indicator
Garzas d5292e9
keep asset local-path VMs stable in lazy list scope
Garzas 59c3cb5
fix: keep swipe wrapper stable to avoid recomposition regression
Garzas c506b69
chore: move preload dedup to ConversationAudioMessagePlayer
Garzas e177fc3
Merge branch 'develop' into fix/stabilize-message-media-loading
Garzas 7525d7f
review fixes
Garzas 9f8f62d
review fixes
Garzas b570473
kalium update
Garzas 56dfc68
review fixes
sbakhtiarov d0fac2e
update kalium
sbakhtiarov e377a42
update kalium
sbakhtiarov 456c97e
Merge remote-tracking branch 'origin/develop' into fix/stabilize-mess…
MohamadJaara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
app/src/main/kotlin/com/wire/android/ui/home/conversations/AudioMessageScopeResolver.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Wire | ||
| * Copyright (C) 2026 Wire Swiss GmbH | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see http://www.gnu.org/licenses/. | ||
| */ | ||
|
|
||
| package com.wire.android.ui.home.conversations | ||
|
sbakhtiarov marked this conversation as resolved.
|
||
|
|
||
| import androidx.compose.runtime.staticCompositionLocalOf | ||
| import com.sebaslogen.resaca.KeyInScopeResolver | ||
|
|
||
| val LocalAudioMessageKeyInScopeResolver = staticCompositionLocalOf<KeyInScopeResolver<String>?> { null } | ||
| val LocalAssetLocalPathKeyInScopeResolver = staticCompositionLocalOf<KeyInScopeResolver<String>?> { null } | ||
|
Check warning on line 25 in app/src/main/kotlin/com/wire/android/ui/home/conversations/AudioMessageScopeResolver.kt
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.