Skip to content

fix: guard flash offset+size overflow #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MarkAtwood wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: guard flash offset+size overflow #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions port/posix/posix_flash_file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ int posixFlashFile_Read( void* c,
{
posixFlashFileContext* context = c;
if ( (context == NULL) ||
(offset + size > MAX_OFFSET(context))){
(offset > MAX_OFFSET(context)) ||
(size > MAX_OFFSET(context) - offset)){
return WH_ERROR_BADARGS;
Comment on lines 181 to 184
}

Expand All @@ -205,7 +206,8 @@ int posixFlashFile_Program(void* c,
{
posixFlashFileContext* context = c;
if ( (context == NULL) ||
(offset + size > MAX_OFFSET(context))){
(offset > MAX_OFFSET(context)) ||
(size > MAX_OFFSET(context) - offset)){
return WH_ERROR_BADARGS;
}
Comment on lines 208 to 212

Expand Down Expand Up @@ -242,7 +244,8 @@ int posixFlashFile_Verify( void* c,
uint32_t data_offset = 0;

if ( (context == NULL) ||
(offset + size > MAX_OFFSET(context))){
(offset > MAX_OFFSET(context)) ||
(size > MAX_OFFSET(context) - offset)){
return WH_ERROR_BADARGS;
}
Comment on lines 246 to 250

Expand Down Expand Up @@ -278,7 +281,8 @@ int posixFlashFile_Erase(void* c,
{
posixFlashFileContext* context = c;
if ( (context == NULL) ||
(offset + size > MAX_OFFSET(context))){
(offset > MAX_OFFSET(context)) ||
(size > MAX_OFFSET(context) - offset)){
return WH_ERROR_BADARGS;
}

Expand Down Expand Up @@ -314,7 +318,8 @@ int posixFlashFile_BlankCheck(void* c,
uint32_t this_size = 0;

if ( (context == NULL) ||
(offset + size > MAX_OFFSET(context))){
(offset > MAX_OFFSET(context)) ||
(size > MAX_OFFSET(context) - offset)){
return WH_ERROR_BADARGS;
}

Expand Down
Loading