Skip to content

fix: validate req_size in cert erasetrusted #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MarkAtwood wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: validate req_size in cert erasetrusted #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/wh_server_cert.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,15 @@ int wh_Server_HandleCertRequest(whServerContext* server, uint16_t magic,
whMessageCert_EraseTrustedRequest req = {0};
whMessageCert_SimpleResponse resp = {0};

/* Validate minimum size */
if (req_size < sizeof(req)) {
resp.rc = WH_ERROR_BADARGS;
wh_MessageCert_TranslateSimpleResponse(
magic, &resp, (whMessageCert_SimpleResponse*)resp_packet);
*out_resp_size = sizeof(resp);
break;
}
Comment on lines +935 to +941

/* Convert request struct */
wh_MessageCert_TranslateEraseTrustedRequest(
magic, (whMessageCert_EraseTrustedRequest*)req_packet, &req);
Expand Down
Loading