Add initial support for crypto callbacks. #114
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| # test_cryptocb.py | ||
|
Member
There was a problem hiding this comment. 🟠 [Medium] Missing test coverage for callback error paths and SHA-2 device_id The new tests cover only the happy path for RNG (SHA-1 hash) and default_device_id. There is no coverage for: (a) a callback returning the wrong number of bytes (the Fix: Extend test_cryptocb.py to cover error paths, unsupported-algo fallthrough, and SHA-256/384/512 device routing. |
||
| # | ||
| # Copyright (C) 2026 wolfSSL Inc. | ||
| # | ||
| # This file is part of wolfSSL. (formerly known as CyaSSL) | ||
| # | ||
| # wolfSSL is free software; you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License as published by | ||
| # the Free Software Foundation; either version 2 of the License, or | ||
| # (at your option) any later version. | ||
| # | ||
| # wolfSSL is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program; if not, write to the Free Software | ||
| # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA | ||
| # ty: ignore[possibly-missing-import] | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import struct | ||
|
|
||
| import pytest | ||
| from typing_extensions import override | ||
|
|
||
| from wolfcrypt.exceptions import WolfCryptApiError | ||
| from wolfcrypt._ffi import lib as _lib | ||
| from wolfcrypt.random import Random | ||
|
|
||
| if _lib.SHA_ENABLED: | ||
| from wolfcrypt.hashes import Sha | ||
|
|
||
| if not _lib.CRYPTO_CB_ENABLED: | ||
| pytest.skip("Crypto Callbacks not supported", allow_module_level=True) | ||
|
|
||
| from wolfcrypt.cryptocb import CryptoCallback | ||
|
|
||
|
|
||
| def test_default_device_id(): | ||
|
Member
There was a problem hiding this comment. 🟠 [Medium] Hash callbacks and error paths are untested; default-device-id test asserts nothing Only the RNG callback path is exercised. There is no coverage for Fix: Add tests for the hash update/finalize paths, the length-mismatch/error paths, and the unknown-algo fallback; make
Contributor
Author
There was a problem hiding this comment. Changed the Added test to check support for crypto callbacks for hash functions. For this some infrastructure had to be added to the |
||
| # In the python implementation the default device ID is the invalid device ID. | ||
| assert CryptoCallback.default_device_id() == _lib.INVALID_DEVID | ||
|
|
||
| class RngCryptoCallback(CryptoCallback): | ||
| @override | ||
| def rng_callback(self, device_id: int, rng: _lib.RNG, size: int) -> bytes: | ||
| # Generate fake random data for testing purposes. | ||
| return bytes(range(1, 1 + size)) | ||
|
|
||
|
|
||
| def test_rng_callback(): | ||
| with RngCryptoCallback(10): | ||
| rng = Random(device_id=10) | ||
|
|
||
| random = rng.byte() | ||
| assert random == b"\01" | ||
|
|
||
| random = rng.bytes(1) | ||
| assert random == b"\01" | ||
|
|
||
| random = rng.bytes(3) | ||
| assert random == b"\01\02\03" | ||
|
|
||
| class HashCryptoCallback(CryptoCallback): | ||
| def __init__(self, device_id): | ||
| super().__init__(device_id) | ||
| self.data: list[bytes] = [] | ||
|
|
||
| @override | ||
| def hash_update_callback(self, device_id: int, hash_type: int, data: bytes) -> None: | ||
| self.data.append(data) | ||
|
|
||
| @override | ||
| def hash_finalize_callback(self, device_id: int, hash_type: int) -> bytes: | ||
| # quite lame hash function, just returns the length of the data as an integer (padded to match the expected hash length). | ||
| return struct.pack("I16x", len(b"".join(self.data))) | ||
|
|
||
|
|
||
| if _lib.SHA_ENABLED: | ||
| def test_hash_callback(): | ||
| with HashCryptoCallback(11): | ||
| sha = Sha(device_id=11) | ||
| sha.update(bytes(10)) | ||
| sha.update(bytes(5)) | ||
| digest = sha.digest() | ||
| assert digest == struct.pack("I16x", 15) | ||
|
|
||
| class BadHashCryptoCallback(CryptoCallback): | ||
| @override | ||
| def hash_finalize_callback(self, device_id: int, hash_type: int) -> bytes: | ||
| return bytes(1) # bad hash length | ||
|
|
||
| if _lib.SHA_ENABLED: | ||
| def test_hash_callback_failure(): | ||
| with BadHashCryptoCallback(12): | ||
| sha = Sha(device_id=12) | ||
| sha.update(bytes(10)) | ||
| with pytest.raises(WolfCryptApiError): | ||
| sha.digest() | ||
Uh oh!
There was an error while loading. Please reload this page.