Fix SFTP_GetAttributes with fatfs for root#974
Conversation
|
Can one of the admins verify this patch? |
|
Hi @J-Goldacker , I don't see you on our approved contributor list. Can you tell us more about your project and use of wolfSSH? For such a small change we may treat this as a bug report. I've assigned this PR to @ejohnstown who is the project owner and can review and decide. Thanks |
|
Hi @dgarske, thank you for assigning the PR. Is this the correct way the give bugfixes we found back to you? (We have licensed your software for Hoppecke Systemtechnik GmbH.) We are using WolfSSH in our BMS (HW: STM32F4, Ethernet, SD Card / SW: STM32CubeHAL, FreeRTOS, FATFS, ...). The problem seems to be specific to newer versions (3.70.x) of FileZilla (which we want to use). Other tools like WinSCP and PSFTP (and FileZilla 3.69.1) don't read the attributes for "/". Do you need more information? Let me know. |
After updating Filezilla to 3.70.5 (from 3.69.1) we got an error message during reception of the directory content. Connecting to a home directory not being root works. (This took us a while to find out.)
We tracked it down to SFTP_GetAttributes where f_stat is called for "/". f_stat doesn't support this and returns FR_INVALID_NAME. Interestingly, the code handling this is mainly there. But the function returns too early.