Clean up UI tests infrastructure#25673
Open
crazytonyli wants to merge 4 commits into
Open
Conversation
UI tests were removed in #25399. This drops the launch-argument flags that nothing passes anymore (logging, prompts, migration, autofill, animations, mock data, screenshot generation) along with their app-side conditionals, reducing UITestConfigurator to the simulator sign-in reset path. The sign-in launch arguments are unaffected.
The WordPress and Jetpack screenshot-generation targets are XCUITest targets that relied on the now-removed UI-test infrastructure. This deletes the targets, their schemes and sources, and the fastlane raw-screenshot lanes, while keeping the promo-screenshot composition and GlotPress download lanes.
With the screenshot-generation targets gone, nothing consumes the UITestsFoundation module or its XcodeTarget wrappers. This removes them and the ScreenObject package dependency they pulled in.
The WireMock mock server, its rake task, the Buildkite UI-test runner, and the Jetpack UI-test branch of the test_without_building lane only supported the removed UI tests. This deletes them along with the obsolete UI-tests documentation.
Collaborator
Generated by 🚫 Danger |
crazytonyli
changed the title
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32719 | |
| Version | PR #25673 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c0fcbc5 | |
| Installation URL | 5d2qe8hi5psig |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32719 | |
| Version | PR #25673 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c0fcbc5 | |
| Installation URL | 3fh3e9eiflrsg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I recommend reviewing commit by commit.
The UI tests were removed in #25399, but there are some surrounding areas (mocks, screen objects, etc) left in the codebase.
The screenshot generation pipeline uses UI tests. This PR removes the screenshot generation automation. We can figure out a new way to do it next time we need new screenshots. I imagine it'd be easier to use LLM for that than UI tests + mocks.