Skip to content

Accept URLs when optimizing site icons - #25868

Open
crazytonyli wants to merge 1 commit into
fix/wpcom-host-allowlist-sharedfrom
fix/site-icon-optimized-url
Open

Accept URLs when optimizing site icons#25868
crazytonyli wants to merge 1 commit into
fix/wpcom-host-allowlist-sharedfrom
fix/site-icon-optimized-url

Conversation

@crazytonyli

Copy link
Copy Markdown
Contributor

Description

Change path: String to url: URL, to avoid any potential URL parsing issues. This will save use some URL -> String -> URL conversions, since the current callers pass URL.absoluteString as the path.

It'll prevent a potential issue where a scheme-less URL string is passed as path, because URL(string: "i.wp.com/icon.png").host is nil.

@crazytonyli
crazytonyli requested a review from jkmassel August 4, 2026 23:07
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Error
🚫 PR requires at least one label.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number33605
VersionPR #25868
Bundle IDorg.wordpress.alpha
Commit433e972
Installation URL5f4v35n9ej080
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number33605
VersionPR #25868
Bundle IDcom.jetpack.alpha
Commit433e972
Installation URL2jv5bqt5rhppg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants