Skip to content

Upgrade netbox to 4.5#96

Merged
Mark90 merged 3 commits into
core-5.0from
feat/78-update-netbox
May 7, 2026
Merged

Upgrade netbox to 4.5#96
Mark90 merged 3 commits into
core-5.0from
feat/78-update-netbox

Conversation

@Sparrow1029
Copy link
Copy Markdown
Contributor

@Sparrow1029 Sparrow1029 commented May 1, 2026

The items in the issue are

  • Make a new DB snapshot for Netbox (see readme file in repository)
  • Test integration (bootstrapping netbox, creating nodes)
  • Remove enable_federation_v2 patch in netbox python code (see Dockerfile)

To support this some configuration (keys, env vars) had to be added and/or changed

Some issues I found that still need to be resolved:

  • rover-compose is failing, unsure why
    resolving SDL for subgraphs defined in /app/supergraph-config.yaml
    downloading the 'supergraph' plugin from https://rover.apollo.dev/tar/supergraph/aarch64-unknown-linux-gnu/v2.9.3
    the 'supergraph' plugin was successfully installed to /home/rover-user/.rover/bin/supergraph-v2.9.3
    composing supergraph with Federation v2.9.3
    error[E029]: Encountered 2 build errors while trying to build a supergraph.
    
    Caused by:
        UNKNOWN_FEDERATION_LINK_VERSION: [netbox] Invalid version v2.11 for the federation feature in @link directive on schema
        INVALID_GRAPHQL: [netbox] Unknown directive "@key". If you meant the "@key" federation directive, you should use "@key" as it is imported under that name in the @link to the federation specification of this schema.
    
            The subgraph schemas you provided are incompatible with each other. See https://www.apollographql.com/docs/federation/errors/ for more information on resolving build errors.
    

Resolves #78

@Sparrow1029 Sparrow1029 changed the title Make necessary changes to support netbox Upgrade netbox to 4.5 May 2, 2026
@Sparrow1029
Copy link
Copy Markdown
Contributor Author

Though the embedding error goes away locally when I mount in the latest HEAD of orchestrat-core, seems the orchestrator-core:edge image tag is still failing CI

@Sparrow1029 Sparrow1029 requested a review from Mark90 May 5, 2026 17:24
Copy link
Copy Markdown
Contributor

@Mark90 Mark90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mark90 Mark90 merged commit 528555b into core-5.0 May 7, 2026
2 of 3 checks passed
@Mark90 Mark90 deleted the feat/78-update-netbox branch May 7, 2026 15:51
Mark90 added a commit that referenced this pull request May 12, 2026
* Implements breaking changes for Core upgrade 4.x -> 5.x

* Update lockfile

* Bump orchestrator-core to 5.0.0rc1

* Git ignore local claude settings

* Perform upgrade 5.0 steps 3 through 11

* Update settings for LLM-search being the default, and removal of agent code from the core

* Update entrypoint to initialize search indexes on start

* Use edge image

* Temporarily use orchestrator-core from main branch

* Fix deprecation warnings regarding store_process_subscription

* Ensure products are imported

* Update entrypoint.sh for 5.0

* Document how to test orchestrator-core upgrades

* Document orchestrator and embeddings, rearrange varaibles

* Misc doc fixes

* Point orchestrator-core to branch fixes-for-5.0.0rc1-part2

* Remove embeddings.env from orchestrator service as per documentation

* EMBEDDING_API_KEY must be non-empty even when a key is not needed

* Bump orchestrator-core to 5.0.0rc2

* Fix indent

* Add yaml lint pre-commit hook

* Core 5.0 namespaced (#95)

* Temporarily pin core to branch feature/1471-namespace-package

* Apply 50_upgrade script to python code

* Update readme

* Bump orchestrator-core to 5.0.0rc3

* Upgrade netbox to 4.5 (#96)

* Make necessary changes to support netbox

* update supergraph versions

* Change version to 2.11

* Bump orchestrator-core to 5.0.0

* Change orchestrator-core image to latest

---------

Co-authored-by: Skye Griffin <sbgriffin@es.net>
Co-authored-by: Alex Ray <19390913+Sparrow1029@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants