-
Notifications
You must be signed in to change notification settings - Fork 8
feat!: consolidate and rename CLI environment variables #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicknisi
wants to merge
2
commits into
main
Choose a base branch
from
refactor/env-var-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { readdir, readFile } from 'node:fs/promises'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { join } from 'node:path'; | ||
| import { ENV_VAR_CATALOG } from './debug.js'; | ||
|
|
||
| // Resolve the src/ root from this file's location (src/commands/*.spec.ts). | ||
| const SRC_DIR = fileURLToPath(new URL('..', import.meta.url)); | ||
|
|
||
| // Matches dot-access env reads: `process.env.WORKOS_X` and the destructured | ||
| // `env.WORKOS_X` form (e.g. interaction-mode.ts), while the lookbehind excludes | ||
| // identifiers like `projectEnv.WORKOS_X` / `sdkEnv.WORKOS_X`. | ||
| // | ||
| // Coverage is intentionally limited to dot access — it does NOT catch bracket | ||
| // access (`process.env['WORKOS_X']`) or object destructuring | ||
| // (`const { WORKOS_X } = process.env`). Those forms aren't used today; if one is | ||
| // introduced, add the var to the catalog manually. This guard exists to catch | ||
| // the common case, not to be exhaustive. | ||
| const ENV_READ_PATTERN = /(?:process\.env|(?<![\w$])env)\.(WORKOS_[A-Z0-9_]+)/g; | ||
|
|
||
| async function collectTsFiles(dir: string): Promise<string[]> { | ||
| const entries = await readdir(dir, { withFileTypes: true }); | ||
| const files = await Promise.all( | ||
| entries.map(async (entry) => { | ||
| const fullPath = join(dir, entry.name); | ||
| if (entry.isDirectory()) return collectTsFiles(fullPath); | ||
| if (!entry.name.endsWith('.ts')) return []; | ||
| if (entry.name.endsWith('.spec.ts') || entry.name.endsWith('.d.ts')) return []; | ||
| return [fullPath]; | ||
| }), | ||
| ); | ||
| return files.flat(); | ||
| } | ||
|
|
||
| describe('WORKOS_ env var catalog (debug env)', () => { | ||
| it('documents every WORKOS_-prefixed env var read via dot access', async () => { | ||
| const files = await collectTsFiles(SRC_DIR); | ||
| const discovered = new Set<string>(); | ||
|
|
||
| for (const file of files) { | ||
| const contents = await readFile(file, 'utf-8'); | ||
| for (const match of contents.matchAll(ENV_READ_PATTERN)) { | ||
| discovered.add(match[1]); | ||
| } | ||
| } | ||
|
|
||
| const cataloged = new Set(ENV_VAR_CATALOG.map((v) => v.name)); | ||
| const missing = [...discovered].filter((name) => !cataloged.has(name)).sort(); | ||
|
|
||
| expect( | ||
| missing, | ||
| `These WORKOS_ env vars are read in src/ but missing from ENV_VAR_CATALOG in debug.ts: ${missing.join(', ')}`, | ||
| ).toEqual([]); | ||
| }); | ||
|
|
||
| it('has no duplicate or stale entries', () => { | ||
| const names = ENV_VAR_CATALOG.map((v) => v.name); | ||
| expect(new Set(names).size).toBe(names.length); | ||
| // Every cataloged var must use the WORKOS_ prefix (no INSTALLER_* drift). | ||
| expect(names.every((n) => n.startsWith('WORKOS_'))).toBe(true); | ||
| }); | ||
|
greptile-apps[bot] marked this conversation as resolved.
|
||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.