feat(generated): Pipes, PipesProvider, UserManagement (batch 6c21f6dc) - #531
Conversation
Greptile SummaryThis regeneration expands Pipes configuration and authentication models.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking request to retain round-trip coverage for public models that remain active. The new request fields are optional and serialized consistently, and the enum split does not block raw wire values; the only accepted concern is the deletion of regression tests for retained response models. Files Needing Attention: test/workos/test_shared_model_round_trip.rb Important Files Changed
Prompt To Fix All With AI### Issue 1
test/workos/test_shared_model_round_trip.rb:16
**Retained models lose round-trip coverage**
This regeneration removes the only direct round-trip tests for `ObjectSummary`, `ObjectVersion`, `EventSchema`, and `EventListListMetadata`, even though these public models remain in active response-deserialization paths. Future generated field-mapping regressions can therefore reach releases without tests detecting missing, nil, or incorrectly exposed fields.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (2): Last reviewed commit: "chore(generated): add release notes frag..." | Re-trigger Greptile |
| @@ -16,39 +16,6 @@ def test_error_response_round_trip | |||
| fixture.each_key { |k| assert json.key?(k.to_sym) || json.key?(k), "Expected to_h to include key #{k}" } | |||
There was a problem hiding this comment.
Retained models lose round-trip coverage
This regeneration removes the only direct round-trip tests for ObjectSummary, ObjectVersion, EventSchema, and EventListListMetadata, even though these public models remain in active response-deserialization paths. Future generated field-mapping regressions can therefore reach releases without tests detecting missing, nil, or incorrectly exposed fields.
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/workos/test_shared_model_round_trip.rb
Line: 16
Comment:
**Retained models lose round-trip coverage**
This regeneration removes the only direct round-trip tests for `ObjectSummary`, `ObjectVersion`, `EventSchema`, and `EventListListMetadata`, even though these public models remain in active response-deserialization paths. Future generated field-mapping regressions can therefore reach releases without tests detecting missing, nil, or incorrectly exposed fields.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Regenerated SDK from spec changes.
Triggered by workos/openapi-spec@72f2c0b