Normalize line endings in assertions - #334
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves cross-platform reliability of the WP-CLI Behat test suite by normalizing line endings (CRLF → LF) before performing various output/file assertions, reducing failures when command output differs by OS.
Changes:
- Normalize line endings in string comparisons and multiple Then-step assertions (numeric, tables, JSON/YAML/CSV, regex, file reads).
- Add helper utilities to normalize line endings recursively within decoded JSON/YAML structures.
- Add/adjust feature coverage to validate line-ending normalization behavior and tweak an HTTP mocking step command quoting.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Context/ThenStepDefinitions.php |
Normalizes STDOUT/STDERR and file contents before several assertions (tables/JSON/YAML/CSV/regex/numeric/version). |
src/Context/Support.php |
Normalizes line endings in check_string() comparisons and adds normalization helpers (string + recursive data). |
features/http-mocking.feature |
Adjusts quoting in a wp eval invocation. |
features/behat-steps.feature |
Adds a scenario covering CRLF normalization across multiple assertion types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.