Add PIC flag#13
Merged
PeterJohnson merged 3 commits intowpilibsuite:mainfrom Sep 3, 2025
Merged
Conversation
Gold856
approved these changes
Sep 1, 2025
3 tasks
Contributor
Author
|
not sure why mac CI isnt working, appears to be unrelated? |
Contributor
From my very short expirience with mac homebrew, this shouldn't be related in any way, may just be that the version of macos its using already has cmake? Atleast thats what that errors means iirc From my quick google search it seems that is indeed the issue and that mac runners install |
Member
|
Merged the cmake fix so a merge/rebase should fix the build here |
Gold856
approved these changes
Sep 2, 2025
PeterJohnson
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Gold856 can you review?