Fix Path Ordering - #2978
Merged
Merged
Conversation
VirajSalaka
requested review from
AnuGayan,
Arshardh,
CrowleyRajapakse,
HeshanSudarshana,
HiranyaKavishani,
Induwara04,
Krishanx92,
PasanT9,
Piumal1999,
RakhithaRR,
Tharsanan1,
Thushani-Jayasekera,
ashera96,
chamilaadhi,
dushaniw,
hisanhunais,
lasanthaS,
malinthaprasan,
pubudu538,
renuka-fernando,
senthuran16,
tgtshanika,
tharikaGitHub,
tharindu1st and
thivindu
as code owners
July 29, 2026 08:53
Contributor
📝 WalkthroughWalkthroughRoute precedence scoring now compares semantic path segments and falls back to matcher-based scoring when route names lack semantic paths. Unit tests and an integration scenario verify ordering for generated regexes, legacy exact routes, wildcard paths, and overlapping LLM policy paths. ChangesRoute specificity sorting
Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Request
participant EnvoyRoutes
participant RouteSorter
participant LLMPolicy
Request->>EnvoyRoutes: Match request path
EnvoyRoutes->>RouteSorter: Compare overlapping routes
RouteSorter->>LLMPolicy: Select most specific route
LLMPolicy-->>Request: Apply matched policy headers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Krishanx92
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes issues related to the order of routes appearing in envoy config.
Goals
Approach
User stories
Documentation
Automation tests
Security checks
Samples
Related PRs
Test environment