[APIP] Update helm-chart - #3060
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThe PR normalizes policy configuration TOML generated by the gateway Helm chart. It updates chart and gateway image versions across Kubernetes configuration and conformance documentation. It also removes commented configuration documentation from the gateway chart values file. ChangesGateway Helm and release configuration
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@kubernetes/helm/gateway-helm-chart/templates/gateway/gateway-config.yaml`:
- Around line 468-469: Update the policy configuration TOML rendering around
$policyConfigToml so the [policy_configurations] wrapper is removed only when
the serialized map contains no direct scalar or array assignments; preserve it
for direct policy values while still supporting nested JWT/JWKS structures. Add
Helm render coverage for direct scalar and array entries and the nested JWT/JWKS
structure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f589da90-6c83-4737-80b2-088db183324d
📒 Files selected for processing (5)
kubernetes/conformance/README.mdkubernetes/helm/gateway-helm-chart/Chart.yamlkubernetes/helm/gateway-helm-chart/templates/gateway/gateway-config.yamlkubernetes/helm/gateway-helm-chart/values.yamlkubernetes/helm/operator-helm-chart/values.yaml
💤 Files with no reviewable changes (1)
- kubernetes/helm/gateway-helm-chart/values.yaml
| {{- $policyConfigToml := dict "policy_configurations" .Values.gateway.config.policy_configurations | toToml }} | ||
| {{- $policyConfigToml = regexReplaceAll "(?m)^\\[policy_configurations\\]\r?\n" $policyConfigToml "" }} |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Preserve the wrapper for direct policy configuration values.
Line 469 removes [policy_configurations] for every serialized map. For the direct entry shown in gateway/gateway-runtime/policy-engine/internal/config/config_test.go:1616-1649, custom_key = "custom_value" becomes a root-level assignment. The runtime mapping in gateway/gateway-runtime/policy-engine/internal/config/config.go:58 will not load that value into PolicyConfigurations.
Remove the wrapper only when it has no direct assignments. Add a Helm render test for direct scalar and array entries, plus the nested JWT/JWKS structure.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@kubernetes/helm/gateway-helm-chart/templates/gateway/gateway-config.yaml`
around lines 468 - 469, Update the policy configuration TOML rendering around
$policyConfigToml so the [policy_configurations] wrapper is removed only when
the serialized map contains no direct scalar or array assignments; preserve it
for direct policy values while still supporting nested JWT/JWKS structures. Add
Helm render coverage for direct scalar and array entries and the nested JWT/JWKS
structure.
8684f8e to
24d9175
Compare
1 participant
Fixes #2132