Skip to content

fix(a11y): add accessible names to icon-only links #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balajmarius merged 1 commit into from
May 27, 2026
+9 −4
Merged

fix(a11y): add accessible names to icon-only links #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/components/embed-page-footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const EmbedPageFooter = ({

return (
<div className="sticky bottom-0 flex items-center justify-between border-gray-200 border-t bg-gray-100 p-4">
<Link href={`/threads/${id}`} target="_blank">
<Link href={`/threads/${id}`} target="_blank" aria-label={t("embed.openFullConversation")}>
<SvgIconClaudebinXs
size="auto"
className="w-14 transition-colors duration-150 ease-in-out hover:text-orange-50"
Expand Down
6 changes: 5 additions & 1 deletion app/src/components/ui/app-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ const AppBar = ({ className, ...props }: AppBarProps) => {
<Container size="lg">
<div className="flex items-center justify-between pt-3 pb-2">
<div className="flex items-center gap-24">
<Link href="/" className="transition-colors ease-in-out hover:text-orange-50">
<Link
href="/"
aria-label={t("common.claudebinHome")}
className="transition-colors ease-in-out hover:text-orange-50"
>
<SvgIconClaudebinXs size="auto" className="w-14" />
</Link>

Expand Down
2 changes: 1 addition & 1 deletion app/src/components/ui/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const Footer = ({ className, ...props }: FooterProps) => {

<div className="flex flex-col items-stretch justify-between gap-12 pt-3 pb-12 lg:flex-row">
<div className="flex flex-col justify-between gap-4 lg:gap-6">
<Link href="/">
<Link href="/" aria-label={t("common.claudebinHome")}>
<SvgIconClaudebin size="auto" className="max-w-xl" />
</Link>

Expand Down
3 changes: 2 additions & 1 deletion app/src/copy/en-EN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"image": "Image",
"unlisted": "Unlisted",
"sharingSettingsUpdated": "Sharing settings updated",
"sharingSettingsUpdateError": "Failed to update sharing settings"
"sharingSettingsUpdateError": "Failed to update sharing settings",
"claudebinHome": "Claudebin home"
},
"commands": {
"oneClickInstall": "claude plugin marketplace add wunderlabs-dev/claudebin && claude plugin install claudebin@claudebin-marketplace",
Expand Down
Loading