fix(a11y): meet WCAG contrast on default button variant#81
Merged
Conversation
Lighthouse flagged the Login button in the app bar — white text (#ffffff) on the brand orange (#ff6900, bg-orange-50) yields a contrast ratio of ~2.89:1, failing WCAG AA for both normal text (4.5:1) and large text (3:1). Override the inherited text-white with text-gray-100 (#191919) on the default variant. New contrast: ~6.09:1 on the base bg and ~7.34:1 on the orange-150 hover gradient — comfortably AA, near AAA. The default variant is only used in two places in the codebase (AppBar Login when signed out, AppBar Logout when signed in), so this is a visible but scoped design tweak: brand orange preserved, foreground darkens to keep the CTA legible. Note: the outline and danger variants also fail contrast in their hover states (white text on solid orange-50 / red-50), but Lighthouse does not test hover so those weren't flagged. Worth a follow-up PR. Co-authored-by: Cursor <cursoragent@cursor.com>
balajmarius
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lighthouse flagged the Login button in the app bar — white text (#ffffff) on the brand orange (#ff6900, bg-orange-50) yields a contrast ratio of ~2.89:1, failing WCAG AA for both normal text (4.5:1) and large text (3:1).
Override the inherited text-white with text-gray-100 (#191919) on the default variant. New contrast: ~6.09:1 on the base bg and ~7.34:1 on the orange-150 hover gradient — comfortably AA, near AAA.
The default variant is only used in two places in the codebase (AppBar Login when signed out, AppBar Logout when signed in), so this is a visible but scoped design tweak: brand orange preserved, foreground darkens to keep the CTA legible.
Note: the outline and danger variants also fail contrast in their hover states (white text on solid orange-50 / red-50), but Lighthouse does not test hover so those weren't flagged. Worth a follow-up PR.
Summary
Brief description of changes.
Changes
Claudebin Session
🔗 Session Link
Testing
How did you test this?
Checklist
bun checkpassesbun type-checkpasses