-
-
Notifications
You must be signed in to change notification settings - Fork 510
chore: Migrate to Vite+ unified toolchain #2340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Timeraa
wants to merge
17
commits into
wxt-dev:main
Choose a base branch
from
Timeraa:vite-plus-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f10ee2f
chore: Migrate to Vite+ unified toolchain
Timeraa 281a790
ci: Use vp commands in workflows
Timeraa c59eae0
fix: Build all packages before running postinstall tasks
Timeraa b481c74
fix: List all workspace dependencies in postinstall task graph
Timeraa c90cfef
fix: Declare transitive workspace deps in postinstall tasks
Timeraa 2c8b7d3
ci: Generate docs and drop hanging-process reporter
Timeraa ca4069e
test: Update snapshots for vite-plus migration
Timeraa 879b4e3
Revert "test: Update snapshots for vite-plus migration"
Timeraa 5549d7e
fix: Restore e2e snapshots and dedup storage type imports
Timeraa cd20534
test: Replace fragile snapshots with structural assertions
Timeraa a1810a6
test: Expect mkdir rejection to propagate in auto-icons
Timeraa 653abf8
fix: Replace vpx with vp exec for workspace binaries
Timeraa 9332789
fix: Use vp run for postinstall and skip on Netlify
Timeraa 134ed70
fix: Scope postinstall to workspace packages
Timeraa b84f250
fix: Use cross-platform Node script for root postinstall
Timeraa 914809b
chore: Address review feedback by reverting unrelated changes
Timeraa 12bcf69
chore: Revert remaining unrelated changes per review
Timeraa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,6 @@ docs/api/reference | |
| stats.html | ||
| .cache | ||
| *-stats.txt | ||
| .vite-hooks/_ | ||
| CLAUDE.md | ||
| **/CLAUDE.md | ||
|
Comment on lines
+28
to
+29
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not opposed to having context files in the repo. I'd prefer for them to be agent-agnostic, but I don't think there are any community standards around these yet. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24.15.0 |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| vp staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "recommendations": [ | ||
| "davidanson.vscode-markdownlint", | ||
| "esbenp.prettier-vscode", | ||
| "github.vscode-github-actions" | ||
| "github.vscode-github-actions", | ||
| "VoidZero.vite-plus-extension-pack" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| { | ||
| // Set default formatter | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
|
|
||
| "[json]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, | ||
| "[yaml]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, | ||
| "[typescript]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, | ||
| "[markdown]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }, | ||
|
|
||
| // Additional guidelines for Copilot | ||
| "editor.defaultFormatter": "oxc.oxc-vscode", | ||
| "github.copilot.chat.codeGeneration.instructions": [ | ||
| { "file": "CONTRIBUTING.md" } | ||
| { | ||
| "file": "CONTRIBUTING.md" | ||
| } | ||
| ], | ||
| "oxc.enable": true | ||
| "oxc.enable": true, | ||
| "oxc.fmt.configPath": "./vite.config.ts", | ||
| "editor.formatOnSave": true, | ||
| "editor.formatOnSaveMode": "file", | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.oxc": "explicit" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the did between this and vpr?