Skip to content

Add caveat and assumption admonitions to docs#1134

Merged
brendancol merged 2 commits intomasterfrom
issue-1133
Apr 1, 2026
Merged

Add caveat and assumption admonitions to docs#1134
brendancol merged 2 commits intomasterfrom
issue-1133

Conversation

@brendancol
Copy link
Copy Markdown
Contributor

Closes #1133.

Summary

  • New "Caveats & Assumptions" user guide page (caveats.rst) documenting cross-cutting assumptions: WGS84 hardcoded in geodesic functions, float32 output casting, NaN-as-nodata semantics, proximity distance units, dask chunk requirements, GPU memory, dimension ordering.
  • Sphinx admonition blocks (.. danger::, .. warning::, .. caution::, .. tip::, .. note::) added to 9 reference pages (surface, proximity, focal, classification, hydrology, terrain_metrics, multispectral, zonal, pathfinding).
  • Existing .. note:: in data_types.rst upgraded to .. warning:: with .astype() suggestion.

Test plan

  • Verify caveats.rst renders correctly in Sphinx HTML build
  • Verify admonition blocks appear as colored callout boxes on each reference page
  • Spot-check factual accuracy of each caveat against source code
  • Confirm :ref: link to data_types resolves

New user guide page (caveats.rst) collecting the cross-cutting
assumptions: WGS84 hardcoded in geodesic path, float32 output,
NaN-as-nodata, pixel-unit proximity, dask chunk requirements,
GPU memory, and dimension ordering.

Admonition blocks added to existing reference pages: surface,
proximity, focal, classification, hydrology, terrain_metrics,
and the data_types guide.
…1133)

- Proximity EUCLIDEAN returns coordinate-unit distances, not pixels
- Great-circle returns metres, not kilometres
- Terrain metrics output float64, not float32; drop Horn attribution
- Add admonitions to multispectral, zonal, and pathfinding pages
- Clarify haversine section title
@github-actions github-actions bot added the performance PR touches performance-sensitive code label Apr 1, 2026
@brendancol brendancol merged commit fb1916f into master Apr 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance PR touches performance-sensitive code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add caveat and assumption admonitions to docs

1 participant