Remove benchmark stats from README, keep feature matrices (#2287)#2288
Merged
Conversation
brendancol
commented
May 22, 2026
Contributor
Author
brendancol
left a comment
There was a problem hiding this comment.
PR Review: Remove benchmark stats from README, keep feature matrices (#2287)
Blockers (must fix before merge)
None. Clean docs-only deletion.
Suggestions (should fix, not blocking)
README.md:242-- The line "Same-CRS tiles skip reprojection entirely and are placed by direct coordinate alignment." was previously the closing context for the removed Merge performance table. Without that table, it now dangles at the end of the Reproject/Merge/Resample block. Options: (a) leave it, since it is still correct behavior context for the Merge row; (b) move it into the Merge description in the feature matrix so the detail stays attached to the feature; (c) drop it. Mild preference for (b).
Nits (optional improvements)
README.md:209-- The "Consistency:" line previously had a blank line separating it from the write-perf table. After the deletion it sits directly below the "Features" bullet list. Rendered output is still fine because line 208 is empty, so no action needed.
What looks good
- Tight, focused deletion. Only timing tables and the "5-7x faster" claim are gone.
- Feature matrices, projection support matrix, and the pixel-exact consistency note are preserved.
- The "5-7x faster than rioxarray" claim in the GDAL notes section was stripped while keeping the surrounding factual pixel-exact-match context.
- Diff is tight: -59 +1.
Checklist
- No timing tables remain
- No "Xx faster" claims remain
- Feature matrices intact
- Projection support matrix intact
- Pixel-exact consistency note kept (correctness, not benchmark)
- Orphan "Same-CRS tiles" sentence -- see Suggestions
- [n/a] Algorithm correctness, backend parity, NaN handling, test coverage, docstrings -- docs-only change
brendancol
commented
May 22, 2026
Contributor
Author
brendancol
left a comment
There was a problem hiding this comment.
Follow-up review
Addressed the one Suggestion from the previous review:
- Fixed --
README.md:218(the Merge row in the Reproject/Merge/Resample matrix) now carries the "Same-CRS tiles skip reprojection and are placed by direct coordinate alignment" detail in its description column. The orphan sentence at the bottom of the section has been removed (commit f705f4d).
Nit from the previous review was already no-action.
No new findings. PR is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.mdso the document focuses on what features ship and where they run.Benchmarks fit better with the suite that produces them, not the feature landing page.
Closes #2287
Test plan
README.mdrenders cleanly on GitHub (preview)