Skip to content

[ISASamples] Fixed some broken test streams#2033

Merged
CastagnaIT merged 3 commits into
xbmc:Piersfrom
CastagnaIT:isasamples_upd
May 19, 2026
Merged

[ISASamples] Fixed some broken test streams#2033
CastagnaIT merged 3 commits into
xbmc:Piersfrom
CastagnaIT:isasamples_upd

Conversation

@CastagnaIT
Copy link
Copy Markdown
Collaborator

Description

as title

Motivation and context

closes #2008

How has this been tested?

for playready stream since i dont have anymore a compatible device i tested by using EDGE browser
with dash test page https://reference.dashif.org/dash.js/latest/samples/dash-if-reference-player/index.html

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v22 Piers labels May 18, 2026
@kodiai
Copy link
Copy Markdown

kodiai Bot commented May 18, 2026

Decision: APPROVE

kodiai response

Decision: APPROVE
Issues: none

Evidence:

  • Review prompt covered 1 changed file.
Review Details
  • Review plan: ready hash=98e049a86496 route=standard task=review.full files=1 lines=48(local-diff) budget=25t/533s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred

  • Review reducer: ready input=2 kept=2 suppressed=0 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=0 severityDemoted=0 graphValidated=0 graphUncertain=0

  • Review candidates: shadow recorded=2 rejected=0 errors=0 artifact=present repo=xbmc-inputstream.adaptive pr=2033 key=kodiai-review-output:v1:inst-109141824:xbmc-inputstream.adaptive:pr-2033:action- delivery=8facbb50-52e0-11f1-9ac0-78ac576b502f

  • Review candidate publication: mode=blocked approved=2 rewritten=0 published=0 directFallback=0 reasons=candidate-publisher-blocked

  • Files reviewed: 1

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +27 -21

  • Profile: strict (auto, lines changed: 48)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Shadow specialist: lane=docs-config-truth status=skipped reason=no-operator-truth-paths candidateCount=0 decisionCount=0 decisionCounts=candidate:0,duplicate:0,disagreement:0,dismissed:0,unclassifiable:0 duplicateCount=0 disagreementCount=0 dismissedCount=0 unclassifiableCount=0 truncatedCandidateCount=0 metricAvailability=token:n,cost:n,latency:n visiblePublicationDenied=true approvalPublicationDenied=true privateOnly=true shadowOnly=true redacted=raw:n,publication:n,approval:n,unsafe:0 correlationKey=351086492643e7e1 deliveryId=8facbb50-52e0-11f1-9ac0-78ac576… reviewOutputKey=kodiai-review-output:v1:inst-10…

  • M072 candidate publication bridge: status=denied; bridgeVersion=candidate-publication-bridge.v1; bridgeId=candidate-publication-record:8f50eb47df1f3bb4f53c9384686f4ed7; recordKey=candidate-publication-record:8f50eb47df1f3bb4f53c9384686f4ed7; correlationKey=candidate-publication-bridge:12f79a17bab8615ee2c2c823ecb9d0b7; source=review-handler-publication; candidateRef=candidate-publication-summary-c3a8e1bd; verification=none; counts=candidateCount:0,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:0,disprovenCount:0,publicationEligibleCount:0,malformedRecordCount:0,unsafeInputFieldCount:0; reasons=no-evidence,publication-ineligible; malformed=none; presence=deliveryId:y,reviewOutputKey:y,upstreamCorrelationKey:y,policyCorrelationKey:y; handoffOwner=available; redaction=privateOnly:y,rawPayloads:n,publicationFields:n,evidencePayloads:n,githubCommentBody:n,reducerRawPayload:n,discardedRawPayload:n,discardedPublicationFields:n,discardedEvidencePayloads:n

  • M070 candidate verification publication: status=mixed; counts=attempted:2,allowed:0,denied:2,published:0,skipped:2,failed:0; verification=verified:0,partially_verified:0,unverified:2,disproven:0,unavailable:0; candidateVerification=candidateCount:2,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:2,disprovenCount:0,publicationEligibleCount:0; denialCounts=no-evidence:2,classifier-fail-closed:2,publication-ineligible:2; reasons=no-evidence,classifier-fail-closed,publication-ineligible; metadata=deliveryId:y,reviewOutputKey:y,correlationKey:y; redaction=privateOnly:y,candidateBodies:n,specialistProse:n,rawPrompts:n,rawModelOutput:n,diffs:n,evidencePayloads:n,rawFingerprints:n,publicationEvidence:n,unsafeFields:2

  • Review completed: 2026-05-18T17:45:08.909Z

  • Total wall-clock: 5m 22s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 1.2s
    • retrieval/context assembly: 2.4s
    • executor handoff: 55s
    • remote runtime: 4m 17s
    • publication: 2.8s
  • Tokens: 128 in / 10,313 out | 0.3845

  • Keyword parsing: No keywords detected

@CastagnaIT CastagnaIT merged commit 92ff8b4 into xbmc:Piers May 19, 2026
11 checks passed
@CastagnaIT CastagnaIT deleted the isasamples_upd branch May 19, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Fix non-breaking change which fixes an issue v22 Piers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlayReady test server is dead

1 participant