Skip to content

[depends] Updated JNI android#2036

Open
CastagnaIT wants to merge 1 commit into
xbmc:Piersfrom
CastagnaIT:jni_upd
Open

[depends] Updated JNI android#2036
CastagnaIT wants to merge 1 commit into
xbmc:Piersfrom
CastagnaIT:jni_upd

Conversation

@CastagnaIT
Copy link
Copy Markdown
Collaborator

@CastagnaIT CastagnaIT commented May 21, 2026

Description

Updated JNI android to last changes

it include fix about isCryptoSchemeSupported that fix wrong SDK version PR: xbmc/libandroidjni#62

also depends on PR: github.com/xbmc/libandroidjni/pull/60

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@@ -1 +1 @@
libandroidjni https://github.com/xbmc/libandroidjni/archive/f2e50b4bb1e529023b96ef1cf535e16ce5c4c082.tar.gz
libandroidjni https://github.com/castagnait/libandroidjni/archive/79f379f68a05abbfb662b7c5fc5d6d2f452369d2.tar.gz
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MAJOR] Dependency source points to personal fork instead of official repository

The URL references github.com/castagnait/libandroidjni instead of github.com/xbmc/libandroidjni. This creates supply chain risk—personal forks can be modified or removed without team oversight.

If upstream PRs #60 and #62 aren't merged yet: either wait for upstream merge, or clearly document in the PR description that this temporarily uses a fork with a plan to revert to official sources once changes are upstream.

Suggested change
libandroidjni https://github.com/castagnait/libandroidjni/archive/79f379f68a05abbfb662b7c5fc5d6d2f452369d2.tar.gz
libandroidjni https://github.com/xbmc/libandroidjni/archive/<commit-hash-after-upstream-merge>.tar.gz

@kodiai
Copy link
Copy Markdown

kodiai Bot commented May 21, 2026

Kodiai Review Summary

What Changed

Updates JNI android dependency to include fixes for isCryptoSchemeSupported SDK version handling.

Reviewed: core logic, docs

Observations

Impact

[MAJOR] depends/android/libandroidjni/libandroidjni.txt (1): Dependency points to personal fork
Causes supply chain risk when fork source at github.com/castagnait/libandroidjni can be modified without team oversight, replacing official github.com/xbmc/libandroidjni source.

Verdict

🔴 Address before merging -- 1 blocking issue(s) found (CRITICAL/MAJOR)

Review Details
  • Files reviewed: 2

  • Findings: 0 critical, 2 major, 0 medium, 0 minor (includes 1 from summary observations)

  • Lines changed: +2 -2

  • Profile: strict (auto, lines changed: 4)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Review completed: 2026-05-21T10:47:51.060Z

  • Total wall-clock: 1m 58s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 1.3s
    • retrieval/context assembly: 2.9s
    • executor handoff: 4.8s
    • remote runtime: 1m 45s
    • publication: 1.3s
  • Tokens: 60 in / 3,466 out | 0.1515

  • Keyword parsing: No keywords detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant