[depends] Updated JNI android#2036
Conversation
| @@ -1 +1 @@ | |||
| libandroidjni https://github.com/xbmc/libandroidjni/archive/f2e50b4bb1e529023b96ef1cf535e16ce5c4c082.tar.gz | |||
| libandroidjni https://github.com/castagnait/libandroidjni/archive/79f379f68a05abbfb662b7c5fc5d6d2f452369d2.tar.gz | |||
There was a problem hiding this comment.
[MAJOR] Dependency source points to personal fork instead of official repository
The URL references github.com/castagnait/libandroidjni instead of github.com/xbmc/libandroidjni. This creates supply chain risk—personal forks can be modified or removed without team oversight.
If upstream PRs #60 and #62 aren't merged yet: either wait for upstream merge, or clearly document in the PR description that this temporarily uses a fork with a plan to revert to official sources once changes are upstream.
| libandroidjni https://github.com/castagnait/libandroidjni/archive/79f379f68a05abbfb662b7c5fc5d6d2f452369d2.tar.gz | |
| libandroidjni https://github.com/xbmc/libandroidjni/archive/<commit-hash-after-upstream-merge>.tar.gz |
Kodiai Review SummaryWhat ChangedUpdates JNI android dependency to include fixes for isCryptoSchemeSupported SDK version handling. Reviewed: core logic, docs ObservationsImpact[MAJOR] depends/android/libandroidjni/libandroidjni.txt (1): Dependency points to personal fork Verdict🔴 Address before merging -- 1 blocking issue(s) found (CRITICAL/MAJOR) Review Details
|
Description
Updated JNI android to last changes
it include fix about isCryptoSchemeSupported that fix wrong SDK version PR: xbmc/libandroidjni#62
also depends on PR: github.com/xbmc/libandroidjni/pull/60
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Types of change
Checklist: