Skip to content

Revert "libprocessgroup: CgroupSetup should fail if a required contro… #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MurtazaKolachi wants to merge 1 commit into
base: sixteen
Choose a base branch
from
Open

Revert "libprocessgroup: CgroupSetup should fail if a required contro… #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libprocessgroup/setup/cgroup_map_write.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ static bool ActivateV2CgroupController(const CgroupDescriptor& descriptor) {

if (!Mkdir(controller->path(), descriptor.mode(), descriptor.uid(), descriptor.gid())) {
LOG(ERROR) << "Failed to create directory for " << controller->name() << " cgroup";
return descriptor.controller()->flags() & CGROUPRC_CONTROLLER_FLAG_OPTIONAL;
return false;
}

return ::ActivateControllers(controller->path(), {{controller->name(), descriptor}});
Expand Down Expand Up @@ -291,8 +291,8 @@ bool CgroupSetup() {
}

if (!SetupCgroup(descriptor)) {
LOG(ERROR) << "Failed to setup " << name << " cgroup";
return false;
// issue a warning and proceed with the next cgroup
LOG(WARNING) << "Failed to setup " << name << " cgroup";
}
}

Expand Down