feat: replace wp-prettier with prettier#116
Open
Yannicvanveen wants to merge 2 commits intomainfrom
Open
Conversation
Yannicvanveen
requested review from
FreakyWizard,
JasperS20,
WybeBosch,
YvetteNikolov,
laravdiemen and
rivanuff
There was a problem hiding this comment.
Pull request overview
This PR updates the @yardinternet/prettier-config workspace to use upstream prettier instead of the wp-prettier npm alias, and adjusts config options accordingly.
Changes:
- Remove
parenSpacingfrom the Prettier overrides in the config export. - Replace the
prettierdependency fromnpm:wp-prettier@^3.0.3to^3.8.3. - Add a new
pnpm-lock.yamlunderpackages/prettier-config/.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/prettier-config/src/index.js | Removes an option (parenSpacing) from the override options. |
| packages/prettier-config/package.json | Switches the prettier dependency from wp-prettier alias to upstream prettier. |
| packages/prettier-config/pnpm-lock.yaml | Introduces a per-package pnpm lockfile for prettier-config dependencies. |
Files not reviewed (1)
- packages/prettier-config/pnpm-lock.yaml: Language not supported
Comment on lines
+1
to
+54
| lockfileVersion: '9.0' | ||
|
|
||
| settings: | ||
| autoInstallPeers: true | ||
| excludeLinksFromLockfile: false | ||
|
|
||
| importers: | ||
|
|
||
| .: | ||
| dependencies: | ||
| '@shufo/prettier-plugin-blade': | ||
| specifier: ^1.16.2 | ||
| version: 1.16.2 | ||
| '@shufo/tailwindcss-class-sorter': | ||
| specifier: ^3.0.1 | ||
| version: 3.0.1 | ||
| '@wordpress/prettier-config': | ||
| specifier: ^4.44.0 | ||
| version: 4.44.0(prettier@3.8.3) | ||
| prettier: | ||
| specifier: ^3.8.3 | ||
| version: 3.8.3 | ||
| prettier-plugin-tailwindcss: | ||
| specifier: ^0.7.3 | ||
| version: 0.7.4(prettier@3.8.3) | ||
|
|
||
| packages: | ||
|
|
||
| '@alloc/quick-lru@5.2.0': | ||
| resolution: {integrity: sha512-UrcABB+4bUrFABwbluTIBErXwvbsU/V7TZWfmbgJfbkwiBuziS9gxdODUyuiecfdGQ85jglMW6juS3+z5TsKLw==} | ||
| engines: {node: '>=10'} | ||
|
|
||
| '@babel/runtime-corejs3@7.29.2': | ||
| resolution: {integrity: sha512-Lc94FOD5+0aXhdb0Tdg3RUtqT6yWbI/BbFWvlaSJ3gAb9Ks+99nHRDKADVqC37er4eCB0fHyWT+y+K3QOvJKbw==} | ||
| engines: {node: '>=6.9.0'} | ||
|
|
||
| '@isaacs/cliui@8.0.2': | ||
| resolution: {integrity: sha512-O8jcjabXaleOG9DQ0+ARXWZBTfnP4WNAqzuiJK7ll44AmxGKv/J2M4TPjxjY3znBCfvBXFzucm1twdyFybFqEA==} | ||
| engines: {node: '>=12'} | ||
|
|
||
| '@jridgewell/gen-mapping@0.3.13': | ||
| resolution: {integrity: sha512-2kkt/7niJ6MgEPxF0bYdQ6etZaA+fQvDcLKckhy1yIQOzaoKjBBjSj63/aLVjYE3qhRt5dvM+uUyfCg6UKCBbA==} | ||
|
|
||
| '@jridgewell/resolve-uri@3.1.2': | ||
| resolution: {integrity: sha512-bRISgCIjP20/tbWSPWMEi54QVPRZExkuD9lJL+UIxUKtwVJA8wW1Trb1jMs1RFXo1CBTNZ/5hpC9QvmKWdopKw==} | ||
| engines: {node: '>=6.0.0'} | ||
|
|
||
| '@jridgewell/sourcemap-codec@1.5.5': | ||
| resolution: {integrity: sha512-cYQ9310grqxueWbl+WuIUIaiUaDcj7WOq5fVhEljNVgRfOUhY9fy2zTvfoqWsnebh8Sl70VScFbICvJnLKB0Og==} | ||
|
|
||
| '@jridgewell/trace-mapping@0.3.31': | ||
| resolution: {integrity: sha512-zzNR+SdQSDJzc8joaeP8QQoCQr8NuYx2dIIytl1QeBEZHJ9uW6hebsrYgbz8hJwUQao3TWCMtmfV8Nu1twOLAw==} | ||
|
|
||
| '@nodelib/fs.scandir@2.1.5': |
Comment on lines
21
to
25
| "@shufo/prettier-plugin-blade": "^1.16.2", | ||
| "@shufo/tailwindcss-class-sorter": "^3.0.1", | ||
| "@wordpress/prettier-config": "^4.44.0", | ||
| "prettier": "npm:wp-prettier@^3.0.3", | ||
| "prettier": "^3.8.3", | ||
| "prettier-plugin-tailwindcss": "^0.7.3" |
Contributor
|
Oeh, why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.