feat: implement connection handling in block attributes and queries#118
Merged
YvetteNikolov merged 2 commits intoFeb 18, 2026
Conversation
YvetteNikolov
requested review from
FreakyWizard,
JasperS20,
WybeBosch,
Yannicvanveen,
hnccox-yard,
laravdiemen and
rivanuff
and removed request for
a team
laravdiemen
approved these changes
Feb 18, 2026
|
|
||
| { enableConnection && | ||
| { enableConnection && ( | ||
| <RadioControl |
Contributor
There was a problem hiding this comment.
Wellicht is het nog mooi om dit in een losse control te doen zodat alles wat met deze radio control te maken heeft in 1 bestand bij elkaar staat?
Contributor
Author
There was a problem hiding this comment.
Naar gekeken maar er komt dan ENORM veel prop drillen. De complexiteit wordt alleen maar groter, de useEffect staat hier perfect met alle benodigde controls om zich heen. Dus ik laat deze hier staan.
Contributor
Author
There was a problem hiding this comment.
RadioControl nog naar een apart bestand gedaan
laravdiemen
reviewed
Feb 18, 2026
| connectionOption, | ||
| setAttributes, | ||
| } ) => { | ||
| if ( ! enableConnection ) { |
Contributor
There was a problem hiding this comment.
Je checkt nu twee keer op enableConnection
YvetteNikolov
force-pushed
the
feat/add-radio-to-connection-control
branch
from
4e4a1a9 to
5511723
Compare
YvetteNikolov
merged commit 3f8ab98
into
feat/connection-posts-backend-and-frontend
2 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Radio control toegevoegd met: