feat/support multiple connections by SimonvanWijhe · Pull Request #125 · yardinternet/wp-query-block

SimonvanWijhe · 2026-03-06T12:04:03Z

Fixes #119

TODO:

meerdere connecties ondersteunen
dubbele connecties samenvoegen
speciale tekens niet escapen
Mogelijkheid toevoegen om meerdere posts per connectie te selecteren

getest in participatie met config:

return [
	'connections' => [
		[
			'from' => 'owc-suggestion',
			'meta_key' => 'suggestion_project',
			'to' => 'owc-project',
		],
		[
			'from' => 'owc-map-suggestion',
			'meta_key' => 'map_suggestion_project',
			'to' => 'owc-project',
		],
		[
			'from' => 'owc-map-suggestion',
			'meta_key' => 'map_suggestion_suggestion',
			'to' => 'owc-suggestion',
		],
	],
];

Screen.Recording.2026-03-10.at.15.28.59.mov

dat sommige posts "geen titel" tonen is een issue in participatie

…elected

github-actions · 2026-03-06T12:04:34Z

Coverage report for commit: bf1609f
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 42.9%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ████████░░░░░░░░░░░░░░░ │ 14.3%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ████████░░░░░░░░░░░░░░░ │ 14.3%
 100% │ ████████████████░░░░░░░ │ 28.6%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution

Summary - Lines: 30.12% | Methods: 58.49%

Files	Lines	Methods	Branches
src/Block
Block.php	-	-	100.00%
BlockAttributes.php	92.54%	93.55%	100.00%
src/Casts
IntCast.php	50.00%	-	100.00%
src/Query
PostQuery.php	-	-	100.00%
QueryInterface.php	100.00%	100.00%	100.00%
src
QueryBlockServiceProvider.php	-	-	100.00%
src/Traits
Helpers.php	100.00%	100.00%	100.00%

_{🤖 comment via lucassabreu/comment-coverage-clover}

Copilot

Pull request overview

Adds support for filtering query results by multiple configured “connections” between post types (issue #119), extending the existing single-connection implementation.

Changes:

Update connection meta-key resolution to return multiple meta_key values per target post type.
Adjust the query-layer connection filter to use whereHas('meta', ...) with whereIn constraints.
Tighten enableConnection() to require connectionPosts to be non-empty.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
src/Query/PostQuery.php	Reworks the connection filter from `hasMeta(...)` to a meta relationship subquery for multi-connection support.
src/Block/BlockAttributes.php	Changes connection meta-key lookup to return multiple keys and alters how selected connection targets are represented.

Comments suppressed due to low confidence (1)

src/Block/BlockAttributes.php:88

The phpdoc for connectedPost() no longer matches what the method returns. It currently builds an array with meta_keys (array) and post_id (list), but the doc says array<string, int> and has an extra }. Updating the docblock (and ideally the return shape/type) will help static analysis and prevent misuse by callers.

	/**
	 * @return array<string, int>}
	 */
	public function connectedPost(): array
	{

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-09T14:48:42Z

@SimonvanWijhe I've opened a new pull request, #127, to work on those changes. Once the pull request is ready, I'll request review from you.

… multiple connections scenarios Co-authored-by: SimonvanWijhe <41121933+SimonvanWijhe@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

laravdiemen · 2026-03-10T15:30:10Z

 			handleChange={ onChange }
 			isClearable={ true }
-			isMulti={ false }
+			isMulti={ true }


Deze moet nu toch weer op false? Want dat werkt toch niet?

Ja dit werkt dus wel :)

Wat niet werkt is wanneer "Select Multiple" is aangevinkt:

Dan slaat acf alle post ID's als een serialized array op in de database.

YvetteNikolov · 2026-03-10T15:52:13Z

+/**
+ * Decodes HTML entities commonly found in post-titles and names
+ *
+ * @param {string} text - The text to decode
+ * @return {string} Decoded text
+ */
+export const decodeEntities = ( text = '' ) => {


Er is hier een wordpress package voor https://developer.wordpress.org/block-editor/reference-guides/packages/packages-html-entities/

Je hoeft hem volgens mij niet te installen, staat op de wp global, dus on top of the file

import { decodeEntities } from '@wordpress/html-entities';

doen

…ructions

…unction

SimonvanWijhe added 3 commits March 5, 2026 16:31

feat: support multiple connections as long as only one post-type is s…

c5edb84

…elected

feat: support multiple connections for multiple post-types

5a24111

feat: support multiple different connections for multiple post-types

dc97258

SimonvanWijhe requested a review from a team as a code owner March 6, 2026 12:04

SimonvanWijhe requested review from Rovasch, ShunLuk, Copilot, dtakken, ictbeheer, mvdhoek1 and rivanuff March 6, 2026 12:04

Copilot started reviewing on behalf of SimonvanWijhe March 6, 2026 12:04 View session

SimonvanWijhe marked this pull request as draft March 6, 2026 12:06

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Comment thread src/Block/BlockAttributes.php

Comment thread src/Query/PostQuery.php Outdated

Comment thread src/Block/BlockAttributes.php

Comment thread src/Block/BlockAttributes.php Outdated

Comment thread src/Block/BlockAttributes.php

SimonvanWijhe requested a review from Copilot March 9, 2026 13:41

Copilot started reviewing on behalf of SimonvanWijhe March 9, 2026 13:42 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

Comment thread src/Block/BlockAttributes.php

Comment thread src/Block/BlockAttributes.php

feat: improve connections query

87c2544

SimonvanWijhe force-pushed the feat/support-multiple-connections branch from df9039d to 87c2544 Compare March 9, 2026 14:48

Copilot AI mentioned this pull request Mar 9, 2026

Add tests for enableConnection() and postConnections() connection-mapping logic #127

Merged

SimonvanWijhe and others added 8 commits March 9, 2026 17:01

feat: decode HTML entities in post titles and names

ab8274a

feat: filter duplicate connection post types before setting connections

2dd7ecd

chore: build assets

a34a44d

docs: improve comment

d6bbb48

test: add tests for enableConnection() and postConnections() covering…

4b44cee

… multiple connections scenarios Co-authored-by: SimonvanWijhe <41121933+SimonvanWijhe@users.noreply.github.com>

fix: rename enableConnections to enableConnection for default attributes

8b3eb3c

fix: add connectionOption to post type select control

291fbe0

feat: support multiple connections of the same relation

cf21177

SimonvanWijhe force-pushed the feat/support-multiple-connections branch from 4cc1640 to cf21177 Compare March 10, 2026 14:26

SimonvanWijhe requested a review from Copilot March 10, 2026 14:38

Copilot started reviewing on behalf of SimonvanWijhe March 10, 2026 14:38 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread src/Query/PostQuery.php Outdated

Comment thread src/Block/BlockAttributes.php

Comment thread assets/components/filters-controls/connection-control.js

Apply suggestions from code review

e13733d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

SimonvanWijhe marked this pull request as ready for review March 10, 2026 15:03

SimonvanWijhe requested a review from a team as a code owner March 10, 2026 15:03

SimonvanWijhe requested review from FreakyWizard, JasperS20, WybeBosch, Yannicvanveen, YvetteNikolov and laravdiemen March 10, 2026 15:04

WybeBosch approved these changes Mar 10, 2026

View reviewed changes

laravdiemen reviewed Mar 10, 2026

View reviewed changes

YvetteNikolov reviewed Mar 10, 2026

View reviewed changes

YvetteNikolov approved these changes Mar 10, 2026

View reviewed changes

SimonvanWijhe and others added 3 commits March 10, 2026 17:29

docs: update README with ACF Post Object Field connection filter inst…

f8ded97

…ructions

style: apply php-cs-fixer changes

565ed84

feat: add html-entities dependency and remove custom decodeEntities f…

bf1609f

…unction

laravdiemen approved these changes Mar 11, 2026

View reviewed changes

SimonvanWijhe merged commit eddb359 into main Mar 12, 2026
5 checks passed

SimonvanWijhe deleted the feat/support-multiple-connections branch March 12, 2026 09:05

Conversation

SimonvanWijhe commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laravdiemen Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

SimonvanWijhe Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

YvetteNikolov Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SimonvanWijhe Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

SimonvanWijhe commented Mar 6, 2026 •

edited

Loading

github-actions Bot commented Mar 6, 2026 •

edited

Loading

YvetteNikolov Mar 10, 2026 •

edited

Loading