fix: dont add terms when they are empty in taxonomyTermSlugs#136
Merged
Conversation
|
Coverage report for commit: acfc9d9 Summary - Lines: 30.68% | Methods: 58.49%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a frontend “no results” bug by preventing empty taxonomy term selections (e.g., news_theme: []) from being included when building taxonomy term slug filters.
Changes:
- Skip taxonomies whose
$termsarray is empty when computingtaxonomyTermSlugs(), avoiding empty taxonomy filters being applied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e7caf19 to
547e7a9
Compare
mvdhoek1
reviewed
Apr 8, 2026
YvetteNikolov
approved these changes
Apr 8, 2026
547e7a9 to
acfc9d9
Compare
SimonvanWijhe
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dit lost een bug op. Stappen om de bug te reproduceren:
In de editor gaat het gewoon goed, maar aan de voorkant krijg je de melding dat er geen resulaten zijn.
Als je dan in de code editor kijkt, dan zie je dit. Het gaat hier fout omdat news_theme een lege array is. Deze PR fixt dit probleem.