Clarify Repl.Mcp sample setup for agent hosts#37
Conversation
|
Addressed the host-configuration review in Per-point response:
Also restored the CLI continuation example with Verification run locally:
I did not find existing GitHub inline review comments or issue comments on this PR to reply to individually, so I am posting this as the review-round response. |
|
@codex please review this pr |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eca93ed653
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
eca93ed to
c6a3c63
Compare
|
Rebased the PR branch onto current Head is now |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6a3c63acc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
dotnet run --project ...launches to an initial build plusdotnet run --no-build --project ... -- mcp serve, with Windows path/quoting notes.samples/08-mcp-server/configs/, using a sharedmcpServersshape for generic/Cursor/Cline/Claude-style clients and a separate VS Codeserversshape.Closes #35.
Verification
python3 -m json.tool samples/08-mcp-server/configs/generic-mcp-client.json— passedpython3 -m json.tool samples/08-mcp-server/configs/vscode.mcp.json— passedgit diff --check— passednpx --yes markdownlint-cli2 '**/*.md'— passed, 0 errors14backslash characters for full JSON path examples)dotnet restore src/Repl.slnx --force— passeddotnet build src/Repl.slnx -c Release -warnaserror --no-restore— passed, 0 warnings/errorsdotnet build samples/08-mcp-server/McpServerSample.csproj -c Release -warnaserror— passed, 0 warnings/errorsdotnet test --solution src/Repl.slnx -c Release --no-build --no-restore— passed, 989 succeeded / 1 skipped / 0 faileddotnet run --no-build --project samples/08-mcp-server/McpServerSample.csproj -- contacts --json— returned valid JSON4b6209a— passed: Lint Documentation, Build and Test (ubuntu-latest), Build and Test (macos-latest), Build/Test/Pack, Shell Completion Smoke; GitHub Release skipped