fix(ci): remove redundant build/ artifacts and publish profile/ directly#443
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job deploying
Fix Cloudflare Pages deploy workflow to avoid lockfile-dependent setup
Jun 12, 2026
ss-o
approved these changes
Jun 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Cloudflare Pages deployment workflow to avoid a failing pnpm/Node setup path, and introduces a committed build/ directory that mirrors the existing profile/ content.
Changes:
- Removed pnpm + Node setup and the
pnpm install/buildstep from the Pages deploy job. - Added a deploy-prep step that rebuilds
build/by copying fromprofile/. - Added a committed
build/tree (README/assets/img) that appears to duplicateprofile/.
Reviewed changes
Copilot reviewed 5 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pages-deployment.yml |
Removes pnpm/Node build steps and stages deployment by copying profile/ into build/ before publishing. |
build/README.md |
Adds a README that duplicates profile/README.md. |
build/assets/.gitignore |
Adds build-scoped ignore rules (duplicative of profile assets in practice). |
build/assets/.gitattributes |
Adds build-scoped attributes file. |
build/assets/.editorconfig |
Adds build-scoped editor configuration. |
build/img/logo.svg |
Adds an SVG asset under build/img. |
build/img/hero.svg |
Adds an SVG asset under build/img. |
build/img/divider.svg |
Adds an SVG asset under build/img. |
build/img/card-turbo.svg |
Adds an SVG asset under build/img. |
build/img/card-plugin-mgr.svg |
Adds an SVG asset under build/img. |
build/img/card-ecosystem.svg |
Adds an SVG asset under build/img. |
build/img/card-community.svg |
Adds an SVG asset under build/img. |
Comments suppressed due to low confidence (1)
.github/workflows/pages-deployment.yml:38
- The workflow rebuilds
build/fromprofile/, but this PR also adds a committedbuild/tree. Keeping both encourages drift and makes the runner-siderm -rf ./build && cp -R profile/. build/unnecessary. Publishingprofile/directly avoids the extra copy step and makes it clear which directory is the source of truth.
- name: Prepare deploy directory
run: |
rm -rf ./build
mkdir -p build
cp -R profile/. build/
- name: "🚀 Publish"
uses: cloudflare/pages-action@f0a1cd58cd66095dee69bfa18fa5efd1dde93bca # v1.5.0
with:
projectName: "zsh"
directory: "build"
- Remove committed build/ directory that duplicated profile/ - Simplify deploy workflow to publish profile/ directly - Add build/ to .gitignore to prevent accidental commits
Copilot
AI
changed the title
Fix Cloudflare Pages deploy workflow to avoid lockfile-dependent setup
fix(ci): remove redundant build/ artifacts and publish profile/ directly
Jun 12, 2026
ss-o
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the committed
build/directory that duplicatedprofile/, simplifies the Cloudflare Pages deploy workflow to publishprofile/directly, and addsbuild/to.gitignoreto prevent it being accidentally re-added.Changes
build/: Deleted the committedbuild/tree (README, assets, images) that was an exact duplicate ofprofile/.rm -rf ./build && cp -R profile/. build/) from.github/workflows/pages-deployment.yml; the publish step now targetsdirectory: "profile"directly..gitignore: Addedbuild/to prevent the directory from being committed again.profile/is now the single source of truth for Cloudflare Pages deployments.Touches
.github/workflows/pages-deployment.yml.gitignore