Skip to content

fix(language): procedure syntax highlighting - #2800

Open
sanny-io wants to merge 1 commit into
zenstackhq:devfrom
sanny-io:fix/procedure-highlighting
Open

fix(language): procedure syntax highlighting#2800
sanny-io wants to merge 1 commit into
zenstackhq:devfrom
sanny-io:fix/procedure-highlighting

Conversation

@sanny-io

@sanny-io sanny-io commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Before

Screenshot From 2026-08-12 20-49-20

After

Screenshot From 2026-08-12 20-50-23

Summary by CodeRabbit

  • Style
    • Improved semantic highlighting for function parameter types.
    • Added consistent function-name highlighting for procedures, functions, and attributes.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 164c6ba7-006e-479d-afa8-dbbdfdfdcd8b

📥 Commits

Reviewing files that changed from the base of the PR and between d7c41d8 and c4ff071.

📒 Files selected for processing (1)
  • packages/language/src/zmodel-semantic.ts

📝 Walkthrough

Walkthrough

The semantic token provider now highlights function parameter types with data field type tokens and procedure declarations with function name tokens. It imports the required AST type guards.

Changes

Semantic highlighting

Layer / File(s) Summary
Extend semantic token coverage
packages/language/src/zmodel-semantic.ts
The semantic token provider imports procedure and function parameter type guards. It highlights function parameter types as data field types and procedures as function names.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to c4ff0

This is a small, localized syntax-highlighting change with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing procedure syntax highlighting.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sanny-io sanny-io changed the title fix: procedure syntax highlighting fix(language): procedure syntax highlighting Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant