refactor(compute): split gpu_engine.go into focused files#77
Merged
Conversation
Extract methods from gpu_engine.go (3521 -> 2245 lines) into three focused files to improve navigability: - gpu_engine_elementwise.go (400 lines): Add/Sub/Mul/Div, scalar ops, Exp/Log/Sin/Cos/Tanh/Pow, Sqrt/Rsqrt, fused RoPE/SwiGLU/RMSNorm, CosineSimilarity, HadamardTransform - gpu_engine_reduction.go (221 lines): Sum, Softmax, ReduceSum/Max/Mean, GPUArgmax, GPUScaledSoftmax, GPUFusedSoftmaxVMul - gpu_engine_memory.go (695 lines): Transpose, Zero/Zeros/Copy, Gather, ScatterAdd, Fill, Split/Concat/Repeat/RepeatInterleave, Reshape, OneHot, ConvertFP16ToF32 Zero behavioral changes. All method signatures identical. Build, vet, and race-detector tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute/gpu_engine.go(3,521 lines) into 4 focused files + coregpu_engine.go: 2,245 lines (core struct, constructor, MatMul dispatch, quantized methods)gpu_engine_elementwise.go: 400 lines (Add/Sub/Mul/Div, unary ops, fused ops)gpu_engine_reduction.go: 221 lines (Softmax, Sum, ArgMax, TopK)gpu_engine_memory.go: 695 lines (Copy, Zero, Reshape, Gather, Split, Concat)gpu_engine_matmul.go: 240 lines (unchanged, created in E63)Closes E64 task T64.1.1.
Test plan
go build ./...passesgo vet ./compute/cleango test ./compute/ -timeout 120spassesgo test -race -timeout 120s ./compute/passes