feat: add insert batch and streaming rate controls#813
Open
jamesgao-jpg wants to merge 3 commits into
Open
Conversation
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Replace environment and CloudInsert-specific batch sizing with a task-level insert batch size shared by CLI, REST, frontend, datasets, and runners. Keep streaming insert rate case-specific and validate its relationship to batching. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jamesgao-jpg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Resolve the TestResult compatibility overlap while preserving legacy insert batch migration and the current upstream backend and runner changes. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This upstream PR supersedes jamesgao-jpg/VectorDBBench#3.
insert_batch_sizeacross CLI, REST, frontend, datasets, runners, metrics, and load-reuse identitystreaming_insert_ratecase-specific and validate that it is positive, at least the batch size, and divisible by itNUM_PER_BATCHand the Cloud Insert-specific batch option with the common task setting--memorydb-pipeline-batch-size, while accepting the legacy serialized fieldCompatibility
--insert-batch-sizeand--streaming-insert-rate--cloud-insert-batch-sizecustom_case.batch_sizeand metricnum_per_batchvalues intoTaskConfig.insert_batch_sizeVerification
make lintmake unittestSigned-off-by: jamesgao-jpg james.gao@zilliz.com