Skip to content

feat: add insert batch and streaming rate controls#813

Open
jamesgao-jpg wants to merge 3 commits into
zilliztech:mainfrom
jamesgao-jpg:insert_rate_batch_size_control
Open

feat: add insert batch and streaming rate controls#813
jamesgao-jpg wants to merge 3 commits into
zilliztech:mainfrom
jamesgao-jpg:insert_rate_batch_size_control

Conversation

@jamesgao-jpg

@jamesgao-jpg jamesgao-jpg commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

This upstream PR supersedes jamesgao-jpg/VectorDBBench#3.

  • add task-level insert_batch_size across CLI, REST, frontend, datasets, runners, metrics, and load-reuse identity
  • keep streaming_insert_rate case-specific and validate that it is positive, at least the batch size, and divisible by it
  • replace NUM_PER_BATCH and the Cloud Insert-specific batch option with the common task setting
  • separate MemoryDB pipeline buffering as --memorydb-pipeline-batch-size, while accepting the legacy serialized field

Compatibility

  • new CLI options: --insert-batch-size and --streaming-insert-rate
  • removed CLI option: --cloud-insert-batch-size
  • old result files migrate Cloud Insert custom_case.batch_size and metric num_per_batch values into TaskConfig.insert_batch_size
  • backend-native request caps and sub-batching remain unchanged

Verification

  • make lint
  • make unittest
  • 86 focused contract, CLI, runner, frontend, rate, reuse, and Cloud Insert tests
  • Milvus 2.6.20 functional probe: configured batch size 7 produced three 7-row insert calls, inserted 21/21 rows, completed indexing, and returned search results
  • server-hosted Streamlit smoke test: both insert controls rendered and browser console had no errors

Signed-off-by: jamesgao-jpg james.gao@zilliz.com

James Gao and others added 2 commits June 30, 2026 03:56
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Replace environment and CloudInsert-specific batch sizing with a task-level
insert batch size shared by CLI, REST, frontend, datasets, and runners. Keep
streaming insert rate case-specific and validate its relationship to batching.

Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jamesgao-jpg
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Resolve the TestResult compatibility overlap while preserving legacy insert
batch migration and the current upstream backend and runner changes.

Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
jamesgao-jpg

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants