feat: add OSS OpenSearch and semantic FTS support#815
Open
jamesgao-jpg wants to merge 25 commits into
Open
Conversation
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Remove filtered FTS dataset, runner, backend, frontend, test, and published result changes while retaining unfiltered OSS OpenSearch and semantic FTS support. Remove the task-local session progress file from the branch. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Preserve current upstream backends and compatibility changes while retaining the unfiltered FTS and OSS OpenSearch work from fts_ver2. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jamesgao-jpg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Restore the filtered full-text search cases, datasets, runners, backend clients, CLI controls, and regression tests removed by 7cd3046. Keep frontend support, generated result artifacts, session files, and documentation excluded from this backend migration. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Apply current Black formatting to the restored filtered-FTS code, use direct integer filter attribute access, and document the intentional runtime error inside the serial-search exception boundary. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Assign FTS filter IDs through a versioned affine permutation so threshold filters preserve exact cardinality while spreading matches across corpus insertion order. Use the same mapping for semantic qrels and record its parameters in filter statistics for reproducibility. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Expose sequential and permuted FTS filter-ID distributions through the common CLI and FTS case configuration, defaulting to the deterministic permutation. Propagate the selected mode into document insertion, semantic qrel filtering, and versioned result metadata. Changing modes requires reloading the target collection. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds OSS OpenSearch and the backend support needed for both unfiltered and filtered full-text search benchmarking. Filtered FTS frontend presentation and generated result publication remain deferred.
PR #794 introduced the preceding full-text search benchmark foundation used by this work. This PR supersedes #814 with a reduced publication scope. PR #818 introduces shared CLI run-context notes; its commit is incorporated here so these FTS runs can preserve deployment and constraint context in result JSONs.
Changes
--fts-filter-ratecontrolfilter_idvalues with a deterministic bijection so exact-selectivity filters are scattered across corpus insertion order rather than selecting a contiguous suffix--fts-filter-id-distribution [permuted|sequential], defaulting topermuted, and propagate the selected mode through case construction, dataset preparation, qrel filtering, and result metadata--noteand--note-fileCLI options while preserving Pinecone compatibilitymainDeferred Scope
The filtered FTS backend and CLI paths are included, but filtered results are not published in the frontend by this PR.
Compatibility
FTS collections loaded before commit
bf85cf7contain sequentialfilter_idvalues. Reload those collections before running filtered FTS search so stored IDs and semantic qrel filtering use the same mapping. Changing--fts-filter-id-distributionbetweenpermutedandsequentialalso requires reloading the collection.Verification
make lintmake unittest659f739, followed by isolated current-lint compatibility commita352b73bf85cf7e24110bNo live provider probe was run for this update; provider request translation is covered by mocked unit tests.