Ota upgrade updates#1475
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly (reasonably!) minor tweaks and quality of life improvements with OTA notifications to the application.
An
OTA_STARTEDnotification was added - this is called when the OTA actually starts (betweenOTA_WAITINGandOTA_TRANSFER_IN_PROGRESS.The console command has been improved to provide more status on the upgrade - and hence a few extra getters were added to the extension.
I found a device which persistently stores the update (ie it persists a power cycle). When the power comes on, it sends the
UpgradeEndRequest. The ZCL doc states that it should be possible to send aDefaultResponseas a notification to fail this request, but nothing I could do would reset the device, so at this stage I send theUpgradeEndResponse.