fix(frontend): repair SessionsTable JSX from botched merge#4822
Conversation
The main->big-agents merge left a duplicate ternary and a mismatched
<div>/</SessionStoreProvider> wrapper, breaking prettier, eslint and the
web build. Unite both sides: wrap in SessionStoreProvider, keep one
table with store={store} and the flex-1 layout class.
Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
dosubot
Bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The merge added a defaulted is_agent flag to workflowFlagsSchema, but the agent-playground ephemeral workflow constructed its flags without it. With the literal true/false flag values, the 'as Workflow' cast then failed bidirectional overlap (TS2352), breaking the agenta-web build. Set is_agent from the workflow type. Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
Two more tsc --noEmit failures broke the agenta-web build (turbo builds each package before the app): - agentRequest.ts: annotate headers as Record<string,string> so the conditional header-factory spread does not narrow away the index signature (Authorization access, TS2339). - AgentConfigControl.tsx: drop the stale 'default' key from CONNECTION_MODE_LABELS; ConnectionMode is agenta|self_managed only after the provider-model-auth refactor (TS2353). Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
Railway Preview Environment
|
1 participant
Symptom
The
main→big-agentsmerge (in #4791) broke frontend CI two ways:SessionsTable/index.tsxhad a duplicate{isEmptyState ? ...}ternary and a mismatched<div>…</SessionStoreProvider>wrapper (a hard JSX syntax error).@agenta/entitiesfailed to type-check —appUtils.tsbuilt its ephemeral-workflowflagswithout the newly-added (defaulted)is_agentflag, so theas Workflowcast failed bidirectional overlap (TS2352).next lintdoes not catch this; the build'stscdoes.Fix
SessionsTable: wrap in<SessionStoreProvider>, keep one table retainingstore={store}and theflex-1layout class.is_agent: type === 'agent'in the constructed flags.Verification
prettier --check+eslinton SessionsTable: pass.@agenta/entitiespnpm run types:check: exit 0.https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT