Skip to content

fix(agent): drop skills on Claude wire (restore lost override)#4824

Merged
mmabrouk merged 1 commit into
big-agentsfrom
fix/agent-claude-wire-skills
Jun 24, 2026
Merged

fix(agent): drop skills on Claude wire (restore lost override)#4824
mmabrouk merged 1 commit into
big-agentsfrom
fix/agent-claude-wire-skills

Conversation

@mmabrouk

Copy link
Copy Markdown
Member

Symptom

Application services Unit Test Results (and the aggregated CodeQL check) failed on #4791:
test_invoke_cross_harness_same_body_divergent_configs asserts claude_cfg.wire_skills() == {} but got a populated skills dict.

Root cause

ClaudeAgentConfig must override wire_skills() to return {} — Claude's headless SDK cannot load inline skill packages, so it logs-and-drops them (graceful degrade). That override was dropped in the mainbig-agents merge, so the class fell back to the base wire_skills, which wires the skills.

Fix

Re-add the wire_skills override on ClaudeAgentConfig returning {}.

Verification

  • Target test: 1 passed.
  • Full file: 13 passed.

https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT

ClaudeAgentConfig must override wire_skills to return {} since Claude's
headless SDK cannot load inline skill packages. The override was lost in
the main->big-agents merge, regressing
test_invoke_cross_harness_same_body_divergent_configs.

Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 24, 2026
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jun 24, 2026 5:19pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e887c60-3a42-44e9-89af-8d3bd48dad85

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/agent-claude-wire-skills

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk mmabrouk merged commit 708ae7a into big-agents Jun 24, 2026
25 of 32 checks passed
@mmabrouk mmabrouk deleted the fix/agent-claude-wire-skills branch June 24, 2026 17:26
mmabrouk added a commit that referenced this pull request Jun 24, 2026
…4825)

My earlier #4824 added a ClaudeAgentConfig.wire_skills override returning
{} (graceful-degrade), but that contradicts the authoritative behavior
from 08212c6 (fix(agent): materialize skills for Claude harness): the
runner materializes skills under .claude/skills/<name>, so Claude carries
them on the wire. The override broke the SDK unit test
test_claude_carries_skills_for_project_local_materialization.

Remove the override (Claude inherits the base wire_skills) and update the
stale services-test assertion to expect Claude carries the skill.

Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant