fix(agent): drop skills on Claude wire (restore lost override)#4824
Conversation
ClaudeAgentConfig must override wire_skills to return {} since Claude's
headless SDK cannot load inline skill packages. The override was lost in
the main->big-agents merge, regressing
test_invoke_cross_harness_same_body_divergent_configs.
Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…4825) My earlier #4824 added a ClaudeAgentConfig.wire_skills override returning {} (graceful-degrade), but that contradicts the authoritative behavior from 08212c6 (fix(agent): materialize skills for Claude harness): the runner materializes skills under .claude/skills/<name>, so Claude carries them on the wire. The override broke the SDK unit test test_claude_carries_skills_for_project_local_materialization. Remove the override (Claude inherits the base wire_skills) and update the stale services-test assertion to expect Claude carries the skill. Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
Symptom
Application services Unit Test Results (and the aggregated CodeQL check) failed on #4791:
test_invoke_cross_harness_same_body_divergent_configsassertsclaude_cfg.wire_skills() == {}but got a populatedskillsdict.Root cause
ClaudeAgentConfigmust overridewire_skills()to return{}— Claude's headless SDK cannot load inline skill packages, so it logs-and-drops them (graceful degrade). That override was dropped in themain→big-agentsmerge, so the class fell back to the basewire_skills, which wires the skills.Fix
Re-add the
wire_skillsoverride onClaudeAgentConfigreturning{}.Verification
1 passed.13 passed.https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT