fix: Add accessible name to cancel signing dialog#4296
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe reject confirmation dialog now has ARIA labeling and autofocus wiring, a flex button container class, a signing-specific close-button text resource, and updated modal copy in English, Norwegian Bokmål, and Nynorsk. ChangesReject Dialog Accessibility and Text Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/layout/SigningActions/PanelSigning.tsx`:
- Around line 103-112: The aria-describedby attribute is currently placed on the
Heading element when it should be on the Dialog container itself. Move the
aria-describedby={descId} prop from the Heading component (around line 111) to
the Dialog component (around line 103), and remove it from the Heading element.
This ensures screen readers correctly announce the dialog description as part of
the modal's accessible context rather than describing just the heading.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fd5a71c2-ca5b-4bdd-b100-efbb306c2a8f
📒 Files selected for processing (2)
src/layout/SigningActions/PanelSigning.tsxsrc/layout/SigningActions/SigningActions.module.css
JamalAlabdullah
left a comment
There was a problem hiding this comment.
Tested and it works fine 👍 Need just to fix some tests
…ng-modal-a11y-name
|
|
✅ Automatic backport successful! A backport PR has been automatically created for the The release branch The cherry-pick was clean with no conflicts. Please review the backport PR when it appears. |


Description
Fixes accessibility issues with the "reject signing" confirmation modal so it works correctly with screen readers, addressing issue #4295.
Changes
Illustration of changes to button layout.

Before :
After :

Related Issue(s)
Verification/QA
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit
Summary of changes