ci: add Windows matrix to Android build#726
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
windows-latestto the Android build matrix so we can validate whether #691 is a problem in this library or in the reporter's environment.The report is a CMake link failure when building
react_codegen_safeareacontext.soon Windows with RN 0.82.1 Fabric: every missing symbol is from libc++_shared / libc++abi (std::__ndk1::basic_string,__cxa_*,operator new/delete,vtable for std::exception, …), which suggests the C++ stdlib is not being linked into the codegen library on Windows. Without a Windows machine it's not possible to tell whether this reproduces against our example app or is specific to the reporter's setup.Both
android-build(Paper) andandroid-build-fabric(Fabric) jobs now run on Ubuntu and Windows.defaults.run.shell: bashis set so./gradlewworks the same way on both runners — GitHub-hosted Windows runners ship Git Bash.fail-fast: falsekeeps the existing Ubuntu coverage green even if the Windows job is broken.The example app currently pins
react-native@^0.80.1while the issue is reported against 0.82.1; if the Windows job passes here we'll still need to confirm against 0.82 separately, but a green Windows build on 0.80 + Fabric would already be a strong signal that the codegen CMakeLists is fine and the failure is environmental.Test Plan