Skip to content

ci: add Windows matrix to Android build #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janicduplessis merged 5 commits into from
May 15, 2026
Merged

ci: add Windows matrix to Android build #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a67e0b
ci: add Windows matrix to Android build
janicduplessis May 15, 2026
88833df
ci: use subst on Windows to avoid MAX_PATH in CMake object names
janicduplessis May 15, 2026
901d9b0
ci: merge per-OS build steps into single bash branch
janicduplessis May 15, 2026
01ebb10
ci: extract Android build to scripts/build-android.sh
janicduplessis May 15, 2026
476777c
ci: delegate Windows Android build to companion .cmd file
janicduplessis May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/scripts/build-android.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
@echo off
setlocal
rem subst the workspace to a short drive to avoid Windows MAX_PATH in
rem CMake-generated object file names from autolinked codegen.
subst W: "%GITHUB_WORKSPACE%" || exit /b 1
cd /D W:\example\android || exit /b 1
call gradlew.bat assembleDebug -PnewArchEnabled=%1
12 changes: 12 additions & 0 deletions .github/scripts/build-android.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/usr/bin/env bash
set -euo pipefail

new_arch="${1:-false}"

if [[ "${RUNNER_OS:-}" == "Windows" ]]; then
script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
cmd //c "$(cygpath -w "$script_dir/build-android.cmd")" "$new_arch"
else
cd example/android
./gradlew assembleDebug -PnewArchEnabled="${new_arch}"
fi
24 changes: 18 additions & 6 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,14 @@ on:

jobs:
android-build:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20.x
Expand All @@ -43,10 +50,16 @@ jobs:
run: yarn install
working-directory: example
- name: Build android example app with new arch disabled
run: ./gradlew assembleDebug -PnewArchEnabled=false
working-directory: example/android
run: ./.github/scripts/build-android.sh false
android-build-fabric:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20.x
Expand All @@ -71,5 +84,4 @@ jobs:
run: yarn install
working-directory: example
- name: Build android example app with new arch enabled
run: ./gradlew assembleDebug -PnewArchEnabled=true
working-directory: example/android
run: ./.github/scripts/build-android.sh true
Loading