[AKS] Preserve --max-unavailable in az aks nodepool upgrade#33332
Draft
[AKS] Preserve --max-unavailable in az aks nodepool upgrade#33332
--max-unavailable in az aks nodepool upgrade#33332Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
FumingZhang,
elvazhu521,
yanzhudd and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
Agent-Logs-Url: https://github.com/Azure/azure-cli/sessions/f91cb1b4-ec80-47e4-8ed4-d00db1186538 Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix az aks nodepool upgrade to apply --max-unavailable flag
[AKS] Preserve May 8, 2026
--max-unavailable in az aks nodepool upgrade
Collaborator
|
AKS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks nodepool upgradeDescription
az aks nodepool upgradeaccepted and validated--max-unavailablebut dropped it before the agent pool PUT, so the requested availability budget was never applied.Command behavior
max_unavailableintoinstance.upgrade_settingsinaks_agentpool_upgrade, alongside the existing upgrade settings assignment path.Regression coverage
max_unavailableis preserved on the outgoing agent pool model.Testing Guide
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.pyfor theaz aks nodepool upgradepath with--max-unavailable.History Notes
[AKS]
az aks nodepool upgrade: Preserve--max-unavailablein upgrade requestsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.