fix(geocoding_darwin): declare pigeon as a dev_dependency - #314
Open
bjrochem72 wants to merge 1 commit into
Open
fix(geocoding_darwin): declare pigeon as a dev_dependency#314bjrochem72 wants to merge 1 commit into
bjrochem72 wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
pigeonfromdependenciestodev_dependenciesingeocoding_darwin.Pigeon is a build-time code generator. The generated
lib/src/geocoding/geocoding.g.dartis self-contained and doesn't importpackage:pigeonat runtime, so it doesn't need to be a runtime dependency.geocoding_androidalready declares it underdev_dependencies; this just bringsgeocoding_darwinin line.Because it's a regular dependency today, pigeon is pulled into every app that depends on
geocoding, and pigeon'sanalyzer >=10.0.0 <13.0.0constraint then caps the whole app's analyzer at 12. That blocks any package in the app that needs analyzer 13+. In our project it prevents upgradingriverpod_generator/riverpod_lint(3.4+) anddrift_dev, which all requireanalyzer ^13, and there's no workaround short of droppinggeocodingsince it's the only path pulling pigeon in.Fixes #304.
Verification:
grep -rn "package:pigeon" geocoding_darwin/libreturns nothing (no runtime use).flutter pub getin the example app still resolves.