Skip to content

fix(geocoding_darwin): declare pigeon as a dev_dependency #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjrochem72 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix(geocoding_darwin): declare pigeon as a dev_dependency #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions geocoding_darwin/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 1.0.3

- Moves `pigeon` from `dependencies` to `dev_dependencies`. Pigeon is a
build-time code generator; the generated `geocoding.g.dart` does not import it
at runtime. Declaring it as a runtime dependency leaked pigeon's `analyzer`
version constraint into consuming apps. This matches `geocoding_android`,
which already declares pigeon under `dev_dependencies`. Fixes #304.

## 1.0.2

- Registers the `GeocodingDarwinFactory` class as `dartPluginClass` factory to
Expand Down
4 changes: 2 additions & 2 deletions geocoding_darwin/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: geocoding_darwin
description: |-
A Flutter Geocoding plugin which provides easy geocoding and
reverse-geocoding features for iOS and macOS.
version: 1.0.2
version: 1.0.3
repository: https://github.com/baseflow/flutter-geocoding

environment:
Expand All @@ -13,13 +13,13 @@ dependencies:
flutter:
sdk: flutter
geocoding_platform_interface: ^5.0.0
pigeon: ^26.1.2
plugin_platform_interface: ^2.0.2

dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^6.0.0
pigeon: ^26.1.2

flutter:
plugin:
Expand Down