Skip to content

Sheffield | 26-ITP-jan | Martha Ogunbiyi | Sprint 2 | Book Library#447

Closed
marthak1 wants to merge 19 commits intoCodeYourFuture:mainfrom
marthak1:feature/book-library
Closed

Sheffield | 26-ITP-jan | Martha Ogunbiyi | Sprint 2 | Book Library#447
marthak1 wants to merge 19 commits intoCodeYourFuture:mainfrom
marthak1:feature/book-library

Conversation

@marthak1
Copy link
Copy Markdown

@marthak1 marthak1 commented Apr 15, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Fixed errors in book-library file

@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 added Module-Data-Flows The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 16, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 16, 2026
@marthak1 marthak1 changed the title Sheffield | 26-ITP-jan | Martha Ogunbiyi | Sprint 3 | Book Library Sheffield | 26-ITP-jan | Martha Ogunbiyi | Sprint 2 | Book Library Apr 16, 2026
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 16, 2026
cjyuan
cjyuan reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 16, 2026
@marthak1 marthak1 mentioned this pull request Apr 16, 2026
Open
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
cjyuan
cjyuan reviewed Apr 21, 2026
View reviewed changes
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 21, 2026
marthak1 added 3 commits April 21, 2026 19:30
@marthak1
Refactor element retrieval and library initialization
b7cf828 
Moved element retrieval to the top and removed duplicate declarations.
@marthak1
Remove IDs from buttons in book library
79887c0
@marthak1
Refactor table row clearing in render function
a92aab7 
Replaced old table deletion method with innerHTML clearing.
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 21, 2026
@marthak1
Copy link
Copy Markdown
Author

marthak1 commented Apr 21, 2026

Thanks for the feedback, changes has been made .

cjyuan
cjyuan reviewed Apr 21, 2026
View reviewed changes
Comment thread debugging/book-library/script.js Outdated
Comment on lines 77 to 84
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is a syntax error in your code. It's a good practice to test all changes before pushing them to GitHub for review.

  • Note: You can also add rows to tableBody.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 21, 2026
marthak1 added 2 commits April 21, 2026 22:51
@marthak1
removed bracket
5cdb0e0 
Added missing opening brace for the render function.
@marthak1
Fix row insertion to use tableBody instead of table
9ddeb45
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 21, 2026
cjyuan
cjyuan reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Comment thread debugging/book-library/script.js
Comment on lines +113 to 116
showMessage(`You've deleted: ${deletedTitle}`);
});
}
}
}
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off. Have you successfully enabled "Format on save"?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 22, 2026
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marthak1 @illicitonion @cjyuan