Skip to content

Sheffield | 26-ITP-jan | Martha Ogunbiyi | Sprint 2 | Book Library #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marthak1 wants to merge 19 commits into from
Closed

Sheffield | 26-ITP-jan | Martha Ogunbiyi | Sprint 2 | Book Library #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d7e7b4c
fix error in render function for loo closing missing closing bracket
marthak1 Apr 15, 2026
11e500e
update delete button
marthak1 Apr 15, 2026
de9d89d
update add book function and inputs
marthak1 Apr 15, 2026
3dadc55
fixed delete button
marthak1 Apr 15, 2026
9fb77a9
removed unused comment
marthak1 Apr 15, 2026
da350c1
unco changes in html
marthak1 Apr 15, 2026
2132c95
removed unused comment
marthak1 Apr 15, 2026
856dff7
validate html code
marthak1 Apr 17, 2026
341fded
refactor page count with number type and update element variable names
marthak1 Apr 17, 2026
2a37c41
refactor submit function by using logical NOT to validate input
marthak1 Apr 18, 2026
3ba292d
add html input validation
marthak1 Apr 18, 2026
fa04d30
add efficient approach to remove rows in table, add delete all button…
marthak1 Apr 20, 2026
fc525ce
add form validation in js
marthak1 Apr 20, 2026
da4c5db
Delete .vscode/settings.json
marthak1 Apr 20, 2026
b7cf828
Refactor element retrieval and library initialization
marthak1 Apr 21, 2026
79887c0
Remove IDs from buttons in book library
marthak1 Apr 21, 2026
a92aab7
Refactor table row clearing in render function
marthak1 Apr 21, 2026
5cdb0e0
removed bracket
marthak1 Apr 21, 2026
9ddeb45
Fix row insertion to use tableBody instead of table
marthak1 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 58 additions & 89 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,65 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<html lang="en">

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Book Library</title>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" />
<link rel="stylesheet" type="text/css" href="style.css" />
</head>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
</div>
<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input type="text" class="form-control" id="title" name="title" placeholder="Enter book title..." required />
<label for="author">Author: </label>
<input type="text" class="form-control" id="author" name="author" placeholder="Enter author's name..." required />
<label for="pages">Pages:</label>
<input type="number" class="form-control" id="pages" name="pages" min ="1" placeholder="Enter number of pages..." />
<label class="form-check-label">
<input type="checkbox" class="form-check-input" id="check" value="" />Read
</label>
<input type="submit" value="Submit" class="btn btn-primary" id="submit-btn" />
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>

<script src="script.js" type="module"></script>
</body>

<script src="script.js"></script>
</body>
</html>

122 changes: 76 additions & 46 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,62 @@
let myLibrary = [];

const titleEl = document.getElementById("title");
const authorEl = document.getElementById("author");
const pagesEl = document.getElementById("pages");
const checkEl = document.getElementById("check");
const submitBtnEl = document.getElementById("submit-btn");
const myLibrary = [];
window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
submitBtnEl.addEventListener("click", function (event) {
event.preventDefault();
submit();
});

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
const title = titleEl.value.trim();
const author = authorEl.value.trim();
const pagesRaw = pagesEl.value.trim();

if (!title || !author || !pagesRaw) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}

const pages = Number(pagesRaw);

if (!Number.isInteger(pages) || pages <= 0) {
alert("Pages must be a positive number");
return;
}

const book = new Book(title, author, pages, checkEl.checked);

myLibrary.push(book);
render();

// clear form
titleEl.value = "";
authorEl.value = "";
pagesEl.value = "";
checkEl.checked = false;
}

function Book(title, author, pages, check) {
Expand All @@ -50,54 +66,68 @@ function Book(title, author, pages, check) {
this.check = check;
}

function showMessage(text) {
const msg = document.createElement("p");
msg.textContent = text;
document.body.appendChild(msg);

setTimeout(() => msg.remove(), 2000);
}
function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
const table = document.getElementById("display");
const tableBody = document.querySelector("tbody");
tableBody.innerHTML = ""; // clears all rows

//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let row = tableBody.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
const changeBut = document.createElement("button");
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.innerText = myLibrary[i].check ? "Yes" : "No";
changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
const delBut = document.createElement("button");
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
delBut.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;
myLibrary.splice(i, 1);
render();
showMessage(`You've deleted: ${deletedTitle}`);
});
}
}
}
Comment on lines +113 to 116
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off. Have you successfully enabled "Format on save"?


const deleteAllBtn = document.createElement("button");
deleteAllBtn.textContent = "Delete All";
deleteAllBtn.className = "btn btn-danger";
document.body.appendChild(deleteAllBtn);
deleteAllBtn.addEventListener("click", function () {
if (myLibrary.length === 0) return;

const count = myLibrary.length;

myLibrary.length = 0; // clear all
deleteAllBtn.disabled = myLibrary.length === 0;
render();

showMessage(`Deleted all ${count} books`);
});

Loading