London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Book Library#481
London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Book Library#481miriamjorna wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
miriamjorna
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
You did your homework. Well done.
| window.addEventListener("load", function () { | ||
| populateStorage(); | ||
| }); | ||
| submitButton.addEventListener("click", addBook); |
There was a problem hiding this comment.
Why not also include line 12 inside the window "on load" callback?
There was a problem hiding this comment.
I have no good answer to that. Haste, I think!
| } | ||
| const book = new Book(title, author, pages, readCheckbox.checked); | ||
| myLibrary.push(book); |
There was a problem hiding this comment.
Indentation is off.
Have you successfully enabled "Format on save" and selected "prettier" as your default JS formatter on VS Code?
There was a problem hiding this comment.
Ever since our previous sessions I have religiously double checked if my code was formatted before submitting - except this morning. Apologies!
There was a problem hiding this comment.
You shouldn't have to if you enabled format on save and select prettier as your default JS formatter.
Not only can these automated tools format the code consistently, they can also save us some time.
cjyuan
added
Complete
|
Many thanks CJ! I hope to "meet" you often in future reviews. You really keep us on our toes and I think our interactions should be marked as mentoring sessions :) Thanks again |
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
3 participants
Self checklist
Changelist
Book Library task done. I've also looked at CJ's list of recommended checks.
My apologies for the late submit. It's been a challenge to catch up.